hey albert, friends, you were right. i've reshaped the patch to be smaller and with next to no api polution. c++ vs c ;) .
there's no api stuff i'd plan to later remove. on the contrary, i plan to add functionality, that will also use the reordering mode parameter of TextPage. i've unified the patches for #55977 and #2981, so trying to apply the older patch for #2981 will fail and be not needed. however #2981 is more sexy then #55977 and #55979, these last ones are at the foundation of text handling support, so please apply both my patches for these. #55979 shows and important regression to functionality once was better. i hope my later work on logical text selection would even solve the problem wrongly solved, which lead to #55979. but #55979 is a solution to last, since poppler_page_get_text (PopplerPage *page) has, as you see, no rectangle argument. so no need for rectangle handling. thanks in advance, alex On 11/26/2012 01:53 AM, Albert Astals Cid wrote: > El Dissabte, 24 de novembre de 2012, a les 10:04:38, alex bodnaru va escriure: >> hello friends, >> >> thumbs up for the progress. >> >> however #2981 is more sexy, #55977 resolves a real design bug in a too >> superficial attempt to resolve visual to logical text conversion. > > Are you planning to answer my questions to #55977? > > Cheers, > Albert > >> >> sorry to lobby my own reports and patches (i just know them better), but >> #55979 fixes an even more annoying bug, with no workaround for the glib api >> users. python users rely on glib too. >> >> thanks in advance, >> alex >> >> On 11/23/2012 07:39 AM, Adam Reichold wrote: >>> Hello, >>> >>> Not sure if this question is intended for everybody on the list or >>> only the developers, but I'll just assume it's for everyone: >>> >>> Looking at the feature list and reading the bug tracker, I'd say that >>> thread-safety needs to be rethought. Maybe one could make this a >>> priority for the next release cycle, trying to implement the long-term >>> solution of removing PDFDoc::getXRef and better distributing the >>> workload, maybe under Thomas' and/or Albert's supervision. (I would be >>> happy to help as much as I can, but I am not very knowledgeable about >>> Poppler's internals yet.) >>> >>> Still, I would argue for a third beta since the RTL stuff seems almost >>> like a bug and less like a missing feature and probably affects a lot >>> of people. (I would also include #2981 here, which depends on #55977.) >>> >>> Best regards, Adam. >>> >>> Am 23.11.2012 00:51, schrieb Albert Astals Cid: >>>> Hi guys, if you look at >>>> http://freedesktop.org/wiki/Software/poppler you'll see that there >>>> are 5 features listed for 0.22 and that I just released 0.21.2 that >>>> was supposed to be the last release with new features. >>>> >>>> I don't think we'll be getting all 5 in, but if we create a new >>>> Beta 3 with let's say 1 week more of time maybe we can get 1 or 2 >>>> more in. >>>> >>>> What do you think? >>>> >>>> Cheers, Albert _______________________________________________ >>>> poppler mailing list [email protected] >>>> http://lists.freedesktop.org/mailman/listinfo/poppler >>> >>> _______________________________________________ >>> poppler mailing list >>> [email protected] >>> http://lists.freedesktop.org/mailman/listinfo/poppler >> >> _______________________________________________ >> poppler mailing list >> [email protected] >> http://lists.freedesktop.org/mailman/listinfo/poppler > _______________________________________________ > poppler mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/poppler > _______________________________________________ poppler mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/poppler
