El Dissabte, 26 de gener de 2013, a les 22:53:22, 王璐 va escriure: > I mean it's confusing and not well documented. > Might waste people's time in the following work of poppler, or potential > bugs etc. > > At least a warning comment there would be helpful. > > But as you mentioned, shiftCTMAndClip is good enough to me.
Thomas, anything against the rename? It is true that this function does a bit more than the other xyzCTM, I agree with you that it's not really a priority but i don't think it hurts either. Cheers, Albert > > > > > regards, > - Lu > > On Sat, Jan 26, 2013 at 8:56 PM, Albert Astals Cid <[email protected]> wrote: > > El Dissabte, 26 de gener de 2013, a les 20:40:14, 王璐 va escriure: > > > Hi all, > > > > > > In GfxState.h, this function is declared right after setCTM and > > > > > > concatCTM, which looks like no big deal than the other 2, but actually > > > > also > > > > > modifies clip BBox of the State > > > > > > The only place this function is used is in the functions handling > > > > > > transparency groups in SplashOutputDev.cc. I'm not familiar with that > > > > part, > > > > > but looks like an ad hoc hack. > > > > > > I found this while I want to track all functions that might update > > > > clip > > > > > BBox, this does not make sense to me. Although I've got no better > > > > solution, > > > > > at least it might be more reasonable if we add a new backdoor for clip > > > > BBox > > > > > and change shiftCTM to what it looks like. In this way SplashOutputDev > > > still takes the responsibility, but GfxState is relieved. > > > > > > What do you think ? I can create a patch. > > > > Why do you think this is a problem? > > > > > > To be honest i don't see any need for a change, all these functions are > > internal and not supposed to be used outside the inner world of poppler > > itself, so the function is doing what it should do. > > > > At most we could rename the function, and name it something like > > shiftCTMAndClip or something, would that work for you? > > > > Cheers, > > > > Albert > > > > > regards, > > > - Lu > > > > _______________________________________________ > > poppler mailing list > > [email protected] > > http://lists.freedesktop.org/mailman/listinfo/poppler _______________________________________________ poppler mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/poppler
