El Dijous, 21 de febrer de 2013, a les 01:32:34, [email protected] va escriure: > I havan't have many more comments on this patch. Albert, could you please > comment when have the time? Thanks
Oh sorry, didn't see there was a patch :D Some minor things to fix: * move the initialization to false to the init function * The "Symbol" line seems to be misaligned * It'd be cool if the 13 in getIndexBaseFont was sizeof(base14Fonts)-1 or the correct formula for that that gives you 13 (we use that in some places afaik, do some grep) Besides that if you give me a pdf that gets rendered better with the patch i don't see why we shouldn't commit it. Cheers, Albert > > > > > On Mon, Feb 18, 2013 at 11:29 AM, [email protected] < > > [email protected]> wrote: > > Hi list, > > > > There are some PDF's out there (I don't know how common they are, but at > > least the IRS tax form of 2008 used to have this) that specify fonts like > > /Helv or /HeBo in their DA streams without specifying the corresponding > > font in the resources. You will find a proof-of-concept patch, where I > > refactor the code we use to force ZapDingbats to render any of the > > standard 14 fonts given by the short refs. So the first question is, Do we > > want a feature like this? If so, reviews to make this mergable are most > > than welcome. > > > > > > Greetings > > > > José _______________________________________________ poppler mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/poppler
