"[email protected]" <[email protected]> writes: > but if implementations are similar? do we prefer ours because of > copyright?
Not necessarily, it depends, that's why I said that we need to check carefully the changes to decide. For example, we could keep our implementation if we think it's better, or simply easier to maintain since we already know that code (we wrote/reviewed it). > or do we want to give "some priority" to the original xpdf so it will be > easier to merge in the future? If it's mostly the same code, making future merges easier is a good reason to change our code. > about difficulty, I realized it was more difficult that I thought at the > begining, so it changed my mind. I still want to merge things that would be > useful for us (soc project), but that would be my effort and not part of > soc. Cool > Greetings > > > On Thu, Jun 5, 2014 at 3:24 AM, Carlos Garcia Campos <[email protected]> > wrote: > >> "[email protected]" <[email protected]> writes: >> >> > Mmmm.. by looking at the new "Form" and "AcroForm" classes, there is a >> lot >> > of functionality already implemented by poppler that does not come from >> > Xpdf. What should we do in this case to do the merge? >> >> That parts are the most difficult ones, we need to check the changes >> carefully and see if we prefer our implementation or the xpdf one, and >> merge any other fixes present in our implementation. So, I'm not sure >> that's a good task for GSoC project. >> >> > >> > >> > On Wed, Jun 4, 2014 at 5:50 PM, Albert Astals Cid <[email protected]> wrote: >> > >> >> El Dimecres, 4 de juny de 2014, a les 20:20:17, Carlos Garcia Campos va >> >> escriure: >> >> > Albert Astals Cid <[email protected]> writes: >> >> > > Has anyone done any preliminary diff between 3.03 and 3.04? >> >> > >> >> > I dind't even know it :-P >> >> > >> >> > > How hard is it going to merge? >> >> > >> >> > I guess like usual, some parts trivial and some others quite >> difficult. >> >> > >> >> > > I'm ultra *behind* on reviewing/regtesting existing patches so i >> don't >> >> > > think i'll be able to do this for a while, but is something that >> >> > > defenitely needs doing. >> >> > >> >> > I'll try to find to time to work on this. Maybe we can setup a repo >> like >> >> > last time with the diff, and start merging individual changes to a >> >> > branch. Once a chunk of the diff is merged in the xpdf-304 branch it's >> >> > removed from the diff in the repo until the diff is empty :-) >> >> >> >> Looks good, do you think you can set that up? >> >> >> >> Cheers, >> >> Albert >> >> >> >> > >> >> > > Cheers, >> >> > > >> >> > > Albert >> >> > > >> >> > > _______________________________________________ >> >> > > poppler mailing list >> >> > > [email protected] >> >> > > http://lists.freedesktop.org/mailman/listinfo/poppler >> >> >> >> _______________________________________________ >> >> poppler mailing list >> >> [email protected] >> >> http://lists.freedesktop.org/mailman/listinfo/poppler >> >> >> >> >> > _______________________________________________ >> > poppler mailing list >> > [email protected] >> > http://lists.freedesktop.org/mailman/listinfo/poppler >> >> -- >> Carlos Garcia Campos >> PGP key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462 >> -- Carlos Garcia Campos PGP key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462
pgpkCLhMRKS6g.pgp
Description: PGP signature
_______________________________________________ poppler mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/poppler
