On 31/10/14 18:49, Adam Reichold wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hello Albert, > > Am 31.10.2014 um 00:01 schrieb Albert Astals Cid: >> Hi guys, i made a patch for PSOutputDev and i think it's good, but >> extra set of eyes are never a bad thing. >> >> https://bugs.freedesktop.org/attachment.cgi?id=108708 >> >> Basically it's so that you don't have to pass firstPage-lastPage to >> PSOutputDev and can simply pass an arbitrary set of pages. > > I had a look and I think it is correct. However, I did only test it > using "pdftops" and not using the Glib or Qt code paths. > > As a small style improvement, I would suggest turning "pgi" into a > "size_t" to get rid of the cast. I would also replace "pg" of type > "int" within "writeDocSetup" by a "pgi" of type "size_t" to remove the > cast and any chance of possible confusion, i.e. someone forgetting > that "pg" is not the page number anymore, but an index to the page vector.
I disagree. All arithmetic (including counting) should be done with signed. Leave the unsigned ints for bit manipulation and modular arithmetic. > > I just noticed this had already happened with the error message, so > I'll attach a slightly modified version of your patch. > > Best regards, Adam. > >> Thanks, Albert >> >> P.S: Yes i know i have lots of patches in the queue to review >> P.S.2: I was planning to release 0.28 today but maybe tomorrow or >> over the weekend, i'd like to at least get >> https://bugs.freedesktop.org/show_bug.cgi?id=81724 and >> https://bugs.freedesktop.org/show_bug.cgi?id=85234 in. >> >> _______________________________________________ poppler mailing >> list [email protected] >> http://lists.freedesktop.org/mailman/listinfo/poppler >> > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQEcBAEBAgAGBQJUU0YuAAoJEPSSjE3STU34E3EIAMa7FhJCJwWFnIKtgEFg9LAZ > Oail139anhhyIZ/Mf5sSE1nAjEB0HGbN2nWVpwyM2VvgPy1eQRcYBuaEjpTY3gJG > hqvTj6d/K2+84tcWFitj0mnRPUfXhCUkei5c+heXzIZXAgGtx6FD/Sc0AsZI9Wu0 > LHpP7BruXCqoMovvEWMdgn4ZV2xVqihId88GFbG6mob93dHLTQfYGloqgSwKvE9e > pRKOP8okdHAIycByi0wvuhmlALIXDqVQhsKiF+D5JE+dwiqs0g3rxYPXQapZQa+4 > i/D2S9/aMPhiYVdybqOYtKjUslR2wTWj7BbVk9+BpAVbCeLIk+xMI3adHn4hdmE= > =FjuM > -----END PGP SIGNATURE----- > > > > _______________________________________________ > poppler mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/poppler > _______________________________________________ poppler mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/poppler
