Dear Albert, Thank you for comment!
Albert Astals Cid wrote: > El dimecres, 27 de desembre de 2017, a les 13:47:02 CET, suzuki toshiya va > escriure: >> 1) git-archive should be improved. > > Probably, but out of scope, i'd say :D Indeed. "always root:root" looks too restricted and generic issue for me. I've already written an initial patch adding GNU-tar-like options: https://github.com/git/git/compare/master...mpsuzuki:pullreq-20171227-a but it seems that more works (e.g. feature testing script) are needed to propose something to git maintainers. >> 2) CMakeLists.txt should be improved to harmonize owner/group >> between the initial part and appendix, by using GNU tar >> specific option. > > If you're bored enough to propose a patch, sure. Also I've written a trivial patch for this, and just filed it to bugzilla. https://bugs.freedesktop.org/show_bug.cgi?id=104398 As I commented in the file, if poppler maintainers want to decide after seeing how git maintainers deal with this, please do so. I think this issue is not urgent, except of the people developing the softwares on Unix with root account. >> 3) Just keep as it is now, but the availability of GNU tar >> should be checked, to avoid unexpected error by non-GNU tar. > > Well, i'm actually the only one "real" user of that, so it's fine for me if > it > only works on gnu tar. If someone else ever wants to take over releasing and > they don't use gnu tar they can always try to improve it. Sounds reasonable. Maybe easiest and most portable way would be the extraction of the archive by git once, and add something, and repack it. But doing such before any requests would be overkill. Regards, mpsuzuki > Cheers, > Albert > >> 4) CMakeLists.txt should be improved to work with other >> variants of tar. It is important that owner/group issue. >> >> Regards, >> mpsuzuki >> >> _______________________________________________ >> poppler mailing list >> [email protected] >> https://lists.freedesktop.org/mailman/listinfo/poppler > > > _______________________________________________ > poppler mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/poppler _______________________________________________ poppler mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/poppler
