Hello,
Am 09.01.2018 um 23:41 schrieb Albert Astals Cid:
> +PageTransition& PageTransition::operator=(const PageTransition &other)
> +{
> + if ( this != &other ) {
> + delete data;
> + data = new PageTransitionData(*other.data);
> + }
> +
> + return *this;
> +}
> +
In view of exception safety, I think it would be better to first create
the new data and then destroy the old one, i.e.:
std::unique_ptr<PageTransitionData> newData{new
PageTransitionData(*other.data)};
data.swap(newData);
(assuming PageTransition::data becomes a unique_ptr)
Regards, Adam.
_______________________________________________
poppler mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/poppler
