Am 18.02.2018 um 23:08 schrieb Albert Astals Cid: > El diumenge, 18 de febrer de 2018, a les 16:55:37 CET, Adam Reichold va > escriure: >> Hello, >> >> the attached patch replaced Poppler's internal hash table implementation >> GooHash by std::unordered_map found in the C++ standard library since >> C++11. This continues Poppler's slow drift towards standard library >> containers and removes one of the home-grown data structures with the >> main goals of reducing code size and improving the long term >> maintainability of the code base. > > Do you have any benchmarks on "rendering" speed and code size?
Sorry, not at hand. I will try to prepare them during the week. Concerning code size, a release build of libpoppler.so goes from text data bss dec hex filename 2464034 288852 360 2753246 2a02de libpoppler.so.73.0.0 for the current master to text data bss dec hex filename 2482129 288756 360 2771245 2a492d libpoppler.so.73.0.0 with the patch applied, i.e. a 0.65% increase in binary size. Please note that in my original message, I was referring only to source code size, i.e. git diff --stat master...remove-goo-hash 18 files changed, 168 insertions(+), 803 deletions(-) > Cheers, > Albert Best regards, Adam. >> >> Best regards, Adam. > > > > > _______________________________________________ > poppler mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/poppler >
signature.asc
Description: OpenPGP digital signature
_______________________________________________ poppler mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/poppler
