README.contributors | 13 +++++++++++++ 1 file changed, 13 insertions(+)
New commits: commit ee0bd54496376c18f25d1c863f583598d3ee2632 Author: Martin Packman <[email protected]> Date: Sun Aug 30 22:37:48 2020 +0100 Add gitlab checkbox point to contributors doc As mentioned by @aacid in merge request comments. Also through general note about helpful title and descriptions. diff --git a/README.contributors b/README.contributors index 65cb95a0..8c4162eb 100644 --- a/README.contributors +++ b/README.contributors @@ -35,4 +35,17 @@ clang-format disagrees, just apply the changes suggested by CI and then commit with the --no-verify flag. If you get stuck, don't hesitate to ask the reviewer to help and they will reformat your commits :) +Merge requests +-------------- + +When creating a new merge request on gitlab make sure it has a clear title and +the description includes any extra details that might be helpful for the +reviewer, such as what the aim of the change is and decisions made during +implementation. + +Also, check "Allow commits from members who can merge to the target branch" as +that enables rebase on landing. See the gitlab docs for details: + +https://docs.gitlab.com/ee/user/project/merge_requests/allow_collaboration.html + And keep hacking on poppler! _______________________________________________ poppler mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/poppler
