On Mar 8, 2008, at 12:10 PM, Wayne Davison wrote:

The attached patch turns on more extensive warnings in gcc (-W) and then fixes a bunch of unused-arg warnings and one signed/unsigned comparison
warning.  Non-gcc compilers should be unaffected.

This should help to find problems in the future, and will allow other
packages (such as rsync) to compile the popt code with -W w/o compiler
warnings showing up.

..wayne..<compiler-warnings.diff>

I'm not really sure that adding __attribute__((__unused__)) helps
anything. All of the changes were already marked with splint
/[EMAIL PROTECTED]@*/ which are regularly verified with "make lint".

OTOH the patch hurts nothing but compiler portability complexity.

Added, thanks for the patch.

73 de Jeff
______________________________________________________________________
POPT Library                                           http://rpm5.org
Developer Communication List                       [email protected]

Reply via email to