Hi Vladimir, This webrev contains all the changes to hotspot needed for the port: http://cr.openjdk.java.net/~goetz/wr16/8166730-linuxs390-all/hotspot.wr01/
It includes http://cr.openjdk.java.net/~goetz/wr16/8166560-basic_s390/hotspot.wr03/ http://cr.openjdk.java.net/~goetz/wr16/8166561-basic_C1C2_s390/webrev.01/ http://cr.openjdk.java.net/~goetz/wr16/8166562-scratch_emit/webrev.01/ which are out for review. Further it includes the one change to relocate the pc-relative instructions where we didn't open a bug for yet, and the new s390-files. Altogether this passed all our tests that were running on the weekend on linuxs390. The s390-files though are not yet fully in shape, I'm still editing them to get rid of legacy stuff and SAP JVM specific code. E.g. all the code guarded by #ifdef SAPJVM will go away in the end. I hope to have the final versions by end of this week. Best regards, Goetz. > -----Original Message----- > From: s390x-port-dev [mailto:s390x-port-dev-boun...@openjdk.java.net] > On Behalf Of Vladimir Kozlov > Sent: Montag, 3. Oktober 2016 23:50 > To: Volker Simonis <volker.simo...@gmail.com> > Cc: s390x-port-...@openjdk.java.net; porters-dev@openjdk.java.net; > build-dev <build-...@openjdk.java.net>; HotSpot Open Source Developers > <hotspot-...@openjdk.java.net>; Java Core Libs <core-libs- > d...@openjdk.java.net> > Subject: Re: RFR: JEP draft for Linux/s3990x port > > Hi Volker, > > Can you prepare combined patch (or set of patches) based on latest > reviews together with s390 code as it will be in final push? > > We want to run it through our pre-integration testing to verify that it > does not have problems. > > Thanks, > Vladimir > > On 9/29/16 11:25 AM, Vladimir Kozlov wrote: > > You need to wait when Mark (OpenJDK Lead) move it to Candidate (or > > other) state: > > > > http://cr.openjdk.java.net/~mr/jep/jep-2.0-02.html > > > > Vladimir > > > > On 9/29/16 9:55 AM, Volker Simonis wrote: > >> Hi Vladimir, > >> > >> thanks a lot for reviewing and endorsing the JEP. > >> > >> I've linked all the relevant issues to the JEP (they all have a link > >> to a webrev) and change the state to "Submitted". > >> > >> There's just one more small shared change we need for the port for > >> which we haven't opened a bug now because we are still working on > >> simplifying it. The current version looks as follows: > >> > >> http://cr.openjdk.java.net/~simonis/webrevs/2016/s390x/9000016- > constant_table_offset.patch > >> > >> > >> What are the next steps? Should I add a "jdk9-fc-request" label to t > >> he JEP and add a corresponding "FC Extension Request" comment to it? > >> Or will this be done automatically once I move it to "Candidate"? > >> > >> Is there anything left to do before I can move it to "Candidate" state? > >> > >> Thanks a lot and best regards, > >> Volker > >> > >> > >> > >> > >> On Tue, Sep 27, 2016 at 8:15 PM, Vladimir Kozlov > >> <vladimir.koz...@oracle.com> wrote: > >>> On 9/27/16 10:49 AM, Volker Simonis wrote: > >>>> > >>>> Hi, > >>>> > >>>> can you please review and endorse the following draft JEP for the > >>>> integration of the Linux/s390x port into the jkd9 master repository: > >>>> > >>>> https://bugs.openjdk.java.net/browse/JDK-8166730 > >>> > >>> > >>> Good. > >>> Add links to webrevs in a comment. It will help to get umbrella FC > >>> extension > >>> approval. > >>> > >>>> > >>>> As detailed in the JEP, the Linux/s390x requires very few shared > >>>> changes and we therefore don't foresee any impact on the existing > >>>> platforms at all. Following you can find a short description of the > >>>> planned changes: > >>>> > >>>> hotspot: > >>>> ======= > >>>> > >>>> Out for review: > >>>> 8166560: [s390] Basic enablement of s390 port. > >>>> http://cr.openjdk.java.net/~goetz/wr16/8166560- > basic_s390/hotspot.wr01/ > >>>> > >>>> Reviewed: > >>>> 8166562: C2: Suppress relocations in scratch emit. > >>>> http://cr.openjdk.java.net/~goetz/wr16/8166562- > scratch_emit/webrev.01/ > >>>> > >>>> Will send RFR soon (depends on 8166560): > >>>> 8166561: [s390] Adaptions needed for s390 port in C1 and C2. > >>>> http://cr.openjdk.java.net/~goetz/wr16/8166562- > scratch_emit/webrev.01 > >>> > >>> > >>> Wrong link. > >>> > >>> Thanks, > >>> Vladimir > >>> > >>> > >>>> > >>>> We are still investigating the need of these shared changes: > >>>> > >>>> > http://cr.openjdk.java.net/~goetz/wr16/s390x_patch_queue/hotspot/9000 > 011-pass_PC_to_retAddrOffset.patch > >>>> > >>>> > >>>> > http://cr.openjdk.java.net/~goetz/wr16/s390x_patch_queue/hotspot/9000 > 016-constant_table_offset.patch > >>>> > >>>> > >>>> And finally the patch with the s390x-only platform files. We are still > >>>> editing these to get them into OpenJdk style and shape. > >>>> Hotspot passes most jck, jtreg and spec tests with these. > >>>> > >>>> > http://cr.openjdk.java.net/~goetz/wr16/s390x_patch_queue/hotspot/9000 > 101-zFiles.patch > >>>> > >>>> > >>>> top-level repository: > >>>> =============== > >>>> > >>>> The following is just adding some s390x specific compiler flags to > >>>> flags.m4 > >>>> 8166800: [s390] Top-level build changes required for Linux/s390x > >>>> https://bugs.openjdk.java.net/browse/JDK-8166800 > >>>> > >>>> jdk repository: > >>>> ============ > >>>> > >>>> This one just adds a new jvm.cfg file for s390x > >>>> 8166801: [s390] Add jvm.cfg file for Linux/s390x > >>>> https://bugs.openjdk.java.net/browse/JDK-8166801 > >>>> > >>>> > >>>> And finally we plan to do one more change which fixes the jtreg test > >>>> on Linux/s390x. But this is mainly for the correct detection of the > >>>> platform and for excluding the tests which are not appropriate for > >>>> s390x. > >>>> > >>>> Thank you and best regards, > >>>> Volker > >>>> > >>>