On 16/05/18 12:50, David Holmes wrote:
> On 16/05/2018 9:23 PM, Andrew Dinn wrote:
. . .
>> Well, I am sure you will be pleased to know that those tests all passed.
>
> Very pleased! A little surprised that purely by inspection I was able to
> get the Aarch64 assembly correct. :)
Yes, an impressive debut -- welcome to the aarch64-port team ;-)
>> Unfortunately, a few of the other tier1 tests failed (or, in some cases,
>> failed to run because of setup/compile errors). I am not convinced the
>> are anything to do with your change set. I am rerunning tier1 minus your
>> changes to see if the same failures occur before the patch.
>>
>> I will let you know if anything points a finger at the change set once I
>> am able to compare before with after.
>
> Thanks. I can't yet imagine anything that would cause other tier1
> failures in a platform selective manner.
The hotspot failures were the same before and after. They were mostly
compiler/aot tests, which is no reason to suspect a problem in your
patch. A couple of SA test failures appear to relate to a problem with
jstack -- once again, I believe, no reason to be concerned as regards
your patch.
regards,
Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
