On 9/24/21 1:08 PM, Alan Bateman wrote:
On 24/09/2021 10:50, Aleksey Shipilev wrote:
I can take a look at x86_32.

What is the usual criteria for "passing" Loom implementation? In other
words, what tests should pass to say that the port is good?

Eventually all tests should pass. A more targetted subset to run is

test/jdk/:jdk_lang
test/hotspot/jtreg/runtime/vthread
test/hotspot/jtreg/serviceability/jvmti/vthread

and maybe test/jdk/jdk/internal/vm/Continuation for the initial runs
once you have something running.

All right, thanks. I doing x86_32 here:
  https://github.com/openjdk/loom/pull/65

x86_32 is basically a gateway for 32/64 bit cleanliness, as you can see from the multiple format string changes. If we do ARM32 port, most of this should be fixed anyway.

I also see there is plenty of commented code in the Loom files, long lines, especially around logging and asserts, etc. Since porting work would probably copy-paste some of that, I think cleaning up x86_64 code would be beneficial for everyone.

--
Thanks,
-Aleksey

Reply via email to