On 13/02/2025 9:48 pm, Harald Eilertsen wrote:
On Wed, Feb 05, 2025 at 11:25:51AM +1000, David Holmes wrote:
Hi Harald,
Can you create a PR against mainline so that we can see the scope of the
changes and how they have been implemented?
Here you go:
https://github.com/openjdk/jdk/pull/23611
Thanks for that - much appreciated. I hadn't realized FreeBSD port would
cover x86_64, PPC and Aarch64. The PPC support concerns me a little as
there may be FreeBSD-specific PPC changes that are needed for PPC
systems that are different to what are typically used by the current PPC
port.
The number of makefile changes needed was surprising ... make me wonder
what macOS was doing in some places.
The amount of ifdefs is concerning though somewhat understandable. I see
a mixed approach to other BSD ports - sometimes there is specific code
for them and it has been modified; sometimes the unimplemented not-Apple
code has been completely replaced with whatever works for FreeBSD -
which shows the other BSD ports are incomplete and can't fully function
... so maybe we should dispense with the illusion that there is some
support for them? (just thinking aloud)
What is the relationship between __OpenBSD__ , __FreeBSD__ and
_ALLBSD_SOURCE? The mixed usage is quite confusing.
Overall the amount of changes for hotspot were less than I had expected,
but I was surprised by some of them. There may be scope for additional
code sharing if we can shuffle things around (the existing ports are far
from exemplary - they were largely copy-paste-edit and there is still a
slot of cleanup that could be done).
David
As mentioned in the notes for the PR, this is mainly ment to get your
feedback and as a draft to assess the scope, and to be a base for
discussing how (and if) to proceed with the port.
Looking forward to your thoughts and feedback!
Harald Eilertsen
--
Eilertsens Kodeknekkeri
https://kodeknekkeriet.net
