On Tue, May 07, 2019 at 06:08:00PM -0400, Jeremie Courreges-Anglas wrote:
> On Tue, May 07 2019, Stuart Henderson <[email protected]> wrote:
> > On 2019/05/07 13:29, Ian Darwin wrote:
> >> CVSROOT: /cvs
> >> Module name: ports
> >> Changes by: [email protected] 2019/05/07 13:29:41
> >>
> >> Removed files:
> >> java/junit : Makefile distinfo
> >> java/junit/pkg : DESCR PLIST
> >>
> >> Log message:
> >> Remove junit, no benefit to packaging, OK jca@
> >>
> >
> > geo/jeoip still uses this
>
> Indeed, boo. :-/
>
> I proposed this diff to Ian, we'll see how he prefers to tackle this.
It's weird to have both TEST_DEPENDS and NO_TEST, no?
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/geo/jeoip/Makefile,v
> retrieving revision 1.28
> diff -u -p -r1.28 Makefile
> --- Makefile 24 Mar 2019 22:24:13 -0000 1.28
> +++ Makefile 7 May 2019 21:02:08 -0000
> @@ -20,14 +20,14 @@ MODJAVA_VER= 1.8+
> MODJAVA_BUILD= ant
> MODJAVA_BUILD_TARGET_NAME = jar docs
>
> -BUILD_DEPENDS= java/junit
> -TEST_DEPENDS= net/GeoIP,-db \
> - java/junit
> +TEST_DEPENDS= net/GeoIP,-db
> RUN_DEPENDS= net/GeoIP,-db \
> java/javaPathHelper
> MAKE_ENV=
> CLASSPATH=${LOCALBASE}/share/java/classes/junit/junit.jar
>
> WRKDIST= ${WRKDIR}/jeoip
> +
> +NO_TEST= Yes
>
> do-install:
> ${INSTALL_DATA_DIR} ${MODJAVA_JAR_DIR}
>
>
> --
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
>
--
Antoine
