On Fri, Dec 27, 2019 at 10:20:35AM -0700, Stuart Henderson wrote:
> CVSROOT: /cvs
> Module name: ports
> Changes by: [email protected] 2019/12/27 10:20:35
>
> Modified files:
> x11/gnome/bijiben: Makefile
> x11/gnome/mutter: Makefile
> x11/gnome/recipes: Makefile
> x11/gnome/shell: Makefile
> x11/gnome/tracker: Makefile
>
> Log message:
> Some GNOME ports had pre-build stages to cope with random build ordering
> done by devel/ninja. Remove them as they are no longer necessary now
> that kurt@ has modified ninja to use a deque rather than using a build
> order dependent on pointer addresses (which due to our malloc were
> randomised). ok ajacoutot@
>
I like to stress that the ninja "fix" is hiding dependency problems.
Randomization of heap addresses should not have an impact. I do
understand this is needed atm to get workable bulk builds, but this
commit message sends the message" randomizatioon is bad because it
breaks things".
In my view, randomizaion is good *because* it breaks (already broken)
things.
-Otto
