On Tue Mar 09, 2021 at 05:48:44PM +0000, Stuart Henderson wrote:
> On 2021/03/09 18:35, Rafael Sadowski wrote:
> > On Tue Mar 09, 2021 at 11:32:08AM +0100, Antoine Jacoutot wrote:
> > > On Sat, Mar 06, 2021 at 11:13:45PM -0700, Rafael Sadowski wrote:
> > > > CVSROOT: /cvs
> > > > Module name: ports
> > > > Changes by: [email protected] 2021/03/06 23:13:45
> > > >
> > > > Modified files:
> > > > multimedia/mkvtoolnix: Makefile distinfo
> > > >
> > > > Log message:
> > > > Update mkvtoolnix to 55.0.0
> > >
> > > The no_x11 FLAVOR failed to build for me.
> > > Log attached.
> > >
> > > --
> > > Antoine
> >
> > Thanks for the report. I can't reproduce it, build and package fine
> > here.
> >
> > ld: error: unable to find library -lstdc++fs
> >
> > Other tools link fine more above in the log file.
> >
>
> c++ -fstack-protector-strong -L/usr/local/lib -L/usr/local/lib
> -Llib/avilib-0.6.10 -Llib/librmff -Lsrc/common -o src/tools/ebml_validator
> src/tools/ebml_validator.o src/tools/element_info.o -lmtxcommon
> -L/usr/local/lib -lmatroska -L/usr/local/lib -lebml -lmagic -lz -lFLAC -logg
> -lm -lz -lpugixml -lintl -liconv -lfmt -L/usr/local/lib -lpcre2-8 -lstdc++fs
> -lstdc++ -L/usr/local/lib -ldvdread
>
> It's using clang to compile, linking libstdc++fs from ports-gcc, and
> libstdc++ from base-gcc. Chances of this producing non-broken binaries
> in this case are not all that high.
>
> So there's probably a hidden dep on gcc-libs. Disabling that may make
> the -lstdc++ magically go away but if not then that needs killing too.
>
Stuart thanks for the input. The diff below mkvtoolnix{,no_x11} package on
amd64 even ports-gcc is installed.
Index: Makefile
===================================================================
RCS file: /cvs/ports/multimedia/mkvtoolnix/Makefile,v
retrieving revision 1.101
diff -u -p -u -p -r1.101 Makefile
--- Makefile 7 Mar 2021 06:13:45 -0000 1.101
+++ Makefile 9 Mar 2021 21:33:30 -0000
@@ -3,6 +3,7 @@
COMMENT= create, alter and inspect Matroska files
DISTNAME= mkvtoolnix-55.0.0
+REVISION= 0
CATEGORIES= multimedia x11
@@ -26,6 +27,11 @@ MODRUBY_RUNDEP= No
# C++17
COMPILER = base-clang ports-gcc
+
+# need to add this for gcc
+# revisit when gcc drops it
+EXTRA_ports-gcc = -lstdc++fs
+LDFLAGS += ${EXTRA_${CHOSEN_COMPILER}}
BUILD_DEPENDS= devel/boost \
devel/gettext,-tools \
Index: patches/patch-Rakefile
===================================================================
RCS file: /cvs/ports/multimedia/mkvtoolnix/patches/patch-Rakefile,v
retrieving revision 1.5
diff -u -p -u -p -r1.5 patch-Rakefile
--- patches/patch-Rakefile 19 Jan 2021 19:01:50 -0000 1.5
+++ patches/patch-Rakefile 9 Mar 2021 21:33:30 -0000
@@ -14,3 +14,12 @@ Index: Rakefile
ldflags += " -Llib/libebml/src -Llib/libmatroska/src" if
c?(:EBML_MATROSKA_INTERNAL)
ldflags += " -Llib/fmt/src" if
c?(:FMT_INTERNAL)
ldflags += " #{c(:EXTRA_LDFLAGS)} #{c(:USER_LDFLAGS)}
#{c(:LDFLAGS_RPATHS)} #{c(:BOOST_LDFLAGS)}"
+@@ -1056,8 +1055,6 @@ $common_libs = [
+ :iconv,
+ :fmt,
+ :pcre2,
+- :stdcppfs,
+- "-lstdc++",
+ ]
+
+ $common_libs += [:cmark] if c?(:USE_QT)
