On Thu, May 27, 2010 at 11:14:44PM +0100, Stuart Henderson wrote: > On 2010/05/27 23:08, Antoine Jacoutot wrote: > > On Thu, 27 May 2010, Marco Peereboom wrote: > > > > > On Thu, May 27, 2010 at 08:32:27PM +0100, Stuart Henderson wrote: > > > > On 2010/05/27 14:04, Marco Peereboom wrote: > > > > > Why is this not a flavor? > > > > > > > > Flavors are for when some files are built in different ways > > > > depending on build options (example: some software which links > > > > with several types of database driver, but you have to choose > > > > which one at build time). > > > > > > > > This is done as a subpackage which means the port is built > > > > once, and then split at packaging time, which saves time in bulk > > > > builds (no need to rebuild the exact same stuff a bunch of different > > > > times). Normally this is done for e.g. dlopen()d modules. > > > > > > > > In this case the dictionaries aren't used at all at build time, > > > > they are copied in the fake-install stage after the main build of > > > > Vim has finished. So there is no need for them to be in the same > > > > port at all. It would make sense to move these to a separate port > > > > e.g. ports/editors/vim-spell > > > > > > Well that is really what I meant, just got the lingo wrong. > > > > > > Can this be fixed please? > > > > This can easily be done using a PSEUDO_FLAVOR, I see no reason it > > should be moved to another directory. > > I was taking the lead from some of the other ports (mozilla, openoffice) > where the dictionaries are split off - imho it makes more sense here than > it does for the huge things that relatively few people will build themselves..
The only problem I can see with the way it's currently done is that it forces people to download about 70MB of spellfiles to build Vim, even if they don't want the -spell subpackage. Is that the problem you want fixed? Or is there something worse? Using a PSEUDO_FLAVOR would result in a separate package name for the main package, like vim-7.2.416-gtk2-no_spell. Given this I would guess that a separate port with a dependency on Vim is the cleanest way to do it. I will do that soon unless someone suggests a better idea. BTW, the existing -lang subpackage of Vim works exactly like the new -spell subpackage. So if you complain about -spell you might want to complain about -lang as well (though at 1.3MB it's a much smaller download). Stefan
