On 2023/11/28 15:45, Theo Buehler wrote:
> On Tue, Nov 28, 2023 at 07:39:55AM -0700, Frederic Cambus wrote:
> > CVSROOT:    /cvs
> > Module name:        ports
> > Changes by: [email protected] 2023/11/28 07:39:55
> > 
> > Modified files:
> >     textproc/ripgrep: Makefile 
> > 
> > Log message:
> > ripgrep: trim trailing garbage in COMMENT.
> > 
> 
> I'm pretty sure this was done to unconfuse some syntax highlighters.

Mostly emacs, I think. (vim's can handle it).

> Also, this would have needed a REVISION bump. So either revert or bump,
> please.

Yes, this is a gotcha with make - VAR=<text><whitespace>#<comment>
includes whitespace in the variable.

It doesn't matter much for COMMENT (other than tripping PLIST_DB) but
watch out for things with a direct comparison using ==/!= (iirc this
does matter with USE_LIBTOOL).

Reply via email to