On Thu, 19 Aug 2010, Federico G. Schwindt wrote:
> CVSROOT: /cvs
> Module name: ports
> Changes by: [email protected] 2010/08/19 12:57:50
>
> Log message:
> Import ibus, the intelligent input bus framework.
>
> Status:
>
> Vendor Tag: fgsch
> Release Tags: fgsch_20100819
>
> N ports/inputmethods/ibus/Makefile
> N ports/inputmethods/ibus/distinfo
> N ports/inputmethods/ibus/patches/patch-src_Makefile_in
> N ports/inputmethods/ibus/patches/patch-setup_ibus-setup_in
> N ports/inputmethods/ibus/patches/patch-ibus_common_py
> N ports/inputmethods/ibus/patches/patch-ui_gtk_ibus-ui-gtk_in
> N ports/inputmethods/ibus/patches/patch-ui_gtk_Makefile_in
> N ports/inputmethods/ibus/patches/patch-configure
> N ports/inputmethods/ibus/patches/patch-setup_Makefile_in
> N ports/inputmethods/ibus/patches/patch-bus_Makefile_in
> N ports/inputmethods/ibus/pkg/DESCR
> N ports/inputmethods/ibus/pkg/PLIST
> N ports/inputmethods/ibus/files/README.OpenBSD
>
> No conflicts created by this import
The following construct is banned from ports:
RUN_DEPENDS = ${BUILD_DEPENDS}
With it you are e.g. adding a run dependency on gmake...
You are missing the gconf2 goos in PLIST.
I don't think you should hardcode python versions in patch-configure.
The python MODULE adds PYTHON="${MODPY_BIN}" in CONFIGURE_ENV, maybe you
could use that.
At last you want to remove intl and iconv from WANTLIB and use the
gettext MODULE.
--
Antoine
