On Sun Aug 17, 2025 at 09:26:35AM +0200, Rafael Sadowski wrote:
> On Sat Aug 16, 2025 at 11:02:13AM +0100, Stuart Henderson wrote:
> > On 2025/08/09 23:32, Rafael Sadowski wrote:
> > >   devel/kf6/kfilemetadata: distinfo 
> > 
> > broken on ILP32 archs;
> > 
> > /pobj/kf6-kfilemetadata-6.17.0/kfilemetadata-6.17.0/src/extractors/plaintextextractor.cpp:163:45:
> >  error: non-constant-expression cannot be narrowed from type 'qint64' (aka 
> > 'long long') to 'qsizetype' (aka 'int') in initializer list 
> > [-Wc++11-narrowing]
> > 
> 
> OK?

Thanks Stuart for the report.

I found a patch from FreeBSD which does the same cast but on
different places and committed it. FreeBSD usually goes into
upstream.

https://cgit.freebsd.org/ports/commit/?id=69f4a3e0060cce7a59fe05f726e36d0d5ca80027

> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/kf6/kfilemetadata/Makefile,v
> diff -u -p -r1.6 Makefile
> --- Makefile  16 Mar 2025 07:23:55 -0000      1.6
> +++ Makefile  17 Aug 2025 07:23:36 -0000
> @@ -1,6 +1,7 @@
>  COMMENT =    KDE 6 library for extracting text and metadata
>  
>  DISTNAME =   kfilemetadata-${VERSION}
> +REVISION =   0
>  
>  SHARED_LIBS +=  KF6FileMetaData           0.0 # 0.0
>  
> Index: patches/patch-src_extractors_plaintextextractor_cpp
> ===================================================================
> RCS file: patches/patch-src_extractors_plaintextextractor_cpp
> diff -N patches/patch-src_extractors_plaintextextractor_cpp
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ patches/patch-src_extractors_plaintextextractor_cpp       17 Aug 2025 
> 07:23:36 -0000
> @@ -0,0 +1,17 @@
> +Unbreak on ILP32 archs;
> +
> +/pobj/kf6-kfilemetadata-6.17.0/kfilemetadata-6.17.0/src/extractors/plaintextextractor.cpp:163:45:
>  error: non-constant-expression cannot be narrowed from
> +type 'qint64' (aka 'long long') to 'qsizetype' (aka 'int') in initializer 
> list [-Wc++11-narrowing]
> +
> +Index: src/extractors/plaintextextractor.cpp
> +--- src/extractors/plaintextextractor.cpp.orig
> ++++ src/extractors/plaintextextractor.cpp
> +@@ -160,7 +160,7 @@ void PlainTextExtractor::extract(ExtractionResult* res
> +             break;
> +         }
> + 
> +-        text += codec.decode({chunk.data(), size});
> ++        text += codec.decode({chunk.data(), static_cast<qsizetype>(size)});
> +         if (codec.hasError()) {
> +             qCDebug(KFILEMETADATA_LOG) << "Invalid encoding. Ignoring" << 
> result->inputUrl();
> +             return;
> 

Reply via email to