On 2017/01/28 06:50, Anthony J. Bentley wrote:
> Stuart Henderson writes:
> > Packaging is broken:
> >
> > ===> Building package for sile-0.9.4
> > Create /mnt/packages/i386/all/sile-0.9.4.tgz
> > Missing library for estdc++>=0.0
>
> Thank you. I'm kicking myself for testing on a machine where I had
> icu4c built with the gcc4 module.
>
> > And the DEPs are a bit wonky, you're adding to MODLUA_BUILD_DEPENDS and
> > MODLUA_RUN_DEPENDS, those should be directly in BUILD_DEPENDS/RUN_DEPENDS.
>
> I admit I'm confused at this part. Isn't MODLUA_*_DEPENDS necessary to
> keep them all on the same version of Lua?
>
> Except luakit, every single
> port in tree that depends on luafs/lpeg/luaexpat does so in
> MODLUA_RUN_DEPENDS, even ports like prosody which are not dependencies
> of other ports.
Ugh, I've not noticed that before. In that case, that part is correct in
sile/Makefile as-is.
But the module behaviour is totally at odds with every other module -
python, tcl, gcc, ruby. I'd be a lot happier to get rid of that part of
the magic from lua.port.mk and change module users to standard form like
"RUN_DEPENDS= devel/lpeg,${MODLUA_FLAVOR}" ...