CVSROOT: /cvs
Module name: ports
Changes by: [email protected] 2017/04/19 16:48:51
Modified files:
devel/mercurial: Tag: OPENBSD_6_1 Makefile
Added files:
devel/mercurial/patches: Tag: OPENBSD_6_1 patch-contrib_hg-ssh
patch-mercurial_dispatch_py
patch-tests_test-ssh_t
Log message:
SECURITY: "hg serve --stdio could be tricked into granting authorized
users access to the Python debugger"
"dispatch: protect against malicious 'hg serve --stdio' invocations
(sec)
Some shared-ssh installations assume that 'hg serve --stdio' is a safe
command to run for minimally trusted users. Unfortunately, the messy
implementation of argument parsing here meant that trying to access a
repo named '--debugger' would give the user a pdb prompt, thereby
sidestepping any hoped-for sandboxing. Serving repositories over
HTTP(S) is unaffected.
We're not currently hardening any subcommands other than 'serve'. If
your service exposes other commands to users with arbitrary repository
names, it is imperative that you defend against repository names of
'--debugger' and anything starting with '--config'.
The read-only mode of hg-ssh stopped working because it provided its
hook configuration to "hg serve --stdio" via --config parameter. This
is banned for security reasons now. This patch switches it to directly
call ui.setconfig(). If your custom hosting infrastructure relies on
passing --config to "hg serve --stdio", you'll need to find a
different way to get that configuration into Mercurial, either by
using ui.setconfig() as hg-ssh does in this patch, or by placing an
hgrc file someplace where Mercurial will read it."
Changes backported from 4.1.3.
