On Sun, Sep 16, 2018 at 09:04:00AM +0200, Bjorn Ketelaars wrote:
> On Sun 16/09/2018 08:16, Antoine Jacoutot wrote:
> > On Sat, Sep 15, 2018 at 10:55:44PM -0600, Bjorn Ketelaars wrote:
> > > CVSROOT: /cvs
> > > Module name: ports
> > > Changes by: [email protected] 2018/09/15 22:55:44
> > >
> > > Modified files:
> > > devel/git-cola : Makefile
> > > devel/git-cola/pkg: PLIST
> > >
> > > Log message:
> > > Let git-cola use qtpy from ports instead of bundled version.
> > >
> > > Per kn@'s advice add ${MODPY_FLAVOR} to deps having py flavors. Take
> > > MAINTAINER.
> >
> > That part doesn't make sense to me. Could you explain a bit please?
>
> Discussed off list with kn@:
>
> 21:47 <kn> can you send an updated diff to the list with modpy_flavor added
> to deps?
> 21:52 <bket> let me check this first with you:
> 21:52 <bket> git-cola is currently python2 only because of py-qt4
> 21:53 <bket> does it make sense to add MODPY_FLAVOR to the dep (except
> py-qt4)?
> 21:53 <kn> yes, modpy_flavor is empty as of now
> 21:53 <kn> becuase modpy_version is 2.7
> 21:54 <kn> but regardless of the version if the deps have py flavors, this
> variable should be appended
Huh? No. We never do that systematicaly, look at the rest of the tree.
We only do it when we have python3 has a possible FLAVOR.
> 21:54 <kn> so once we switch or try modpy_version=3.7, deps get along
> 21:55 <kn> otherwise you'd go for git-cola with 3.7 but the deps would still
> use their default flavor being 2.7
> 21:57 <kn> that is, if you now set MODPY_VERSION=${MODPY_DEFAULT_VERSION_3}
> and try to build, none of the dependencies would use python 3
> 21:57 <kn> that's what MODPY_FLAVOR is for
> 22:00 <bket> clear
Moving to python3 has a default will require many more adjustements anyway.
Sorry but I don't think we want to do this now.
--
Antoine
