Probably the particular enums it complains about are only hit on aarch64. It may also be that it already partially has the actual fixes from v8 for this issue:
https://chromium.googlesource.com/v8/v8.git/+/d15d49b09dc7aef9edcc4cf6a0cb2b77a0db203f -Dimitry > On 17 Jul 2023, at 10:33, Nuno Teixeira <[email protected]> wrote: > > (...) > > More strange is that I can only reproduce this on aarch64. amd64 seems to > build fine... > Any clues? > > Nuno Teixeira <[email protected]> escreveu no dia segunda, 17/07/2023 à(s) > 07:53: > I can confirm that it builds. > > Should a PR be open or this is being taken already? > > Thanks, > > Nuno Teixeira <[email protected]> escreveu no dia domingo, 16/07/2023 à(s) > 14:24: > Hello Dimitry! > > Thanks, I didn't see that PR since I only searched node18... > > I'm building it right now with: > > +.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1400091 > +CXXFLAGS+= -Wno-error=enum-constexpr-conversion > +.endif > > Tomorrow I will have results. > > Thanks! > > Dimitry Andric <[email protected]> escreveu no dia domingo, 16/07/2023 à(s) > 14:10: > On 16 Jul 2023, at 14:58, Nuno Teixeira <[email protected]> wrote: > > > > main 1400093 aarch64 > > > > Anyone seeing www/node18 failing (needed for www/firefox)? > > I tried reverting latest 2 committs and same result with 18.16.0. > > > > Any hints? > > > > https://people.freebsd.org/~eduardo/logs/node18/node18-18.16.1.log > > https://people.freebsd.org/~eduardo/logs/node18/node18-18.16.0.log > > These are similar to <https://bugs.freebsd.org/272013>, but instead of > properly fixing it, the can was kicked down the road in > <https://cgit.freebsd.org/ports/commit/?id=ee3e6d5a17a0c78bb56f8d5719de82b8dd49950d>. > > These enums should be fixed by either removing the values outside of the > enum's valid range, or by specifying the enum's underlying type explicitly to > allow for such values. In the near future the -Wno-enum-constexpr-conversion > flag is going to go away! > > -Dimitry > > > > -- > Nuno Teixeira > FreeBSD Committer (ports) > > > -- > Nuno Teixeira > FreeBSD Committer (ports) > > > -- > Nuno Teixeira > FreeBSD Committer (ports)
signature.asc
Description: Message signed with OpenPGP
