David Berghoff <[EMAIL PROTECTED]> wrote:

> --- print/lout/pkg/PLIST-doc.orig     Tue Jun  7 15:03:55 2005
> +++ print/lout/pkg/PLIST-doc  Tue Jun  7 15:03:55 2005
> @@ -0,0 +1,282 @@
> [EMAIL PROTECTED] $OpenBSD$
> +doc/
> +doc/lout/
> +doc/lout/doc/

Is that second doc really necessary?  Just asking ...
 
> --- print/lout/patches/patch-makefile.orig    Tue Jun  7 15:03:55 2005
> +++ print/lout/patches/patch-makefile Tue Jun  7 15:03:55 2005
> @@ -0,0 +1,102 @@
> +--- makefile.orig    Wed Oct 27 10:59:37 2004
> ++++ makefile Sun Jun  5 00:57:44 2005
> +@@ -274,23 +274,24 @@ LIBLOCA = locale
> + CHARIN      = 1
> + CHAROUT     = 0
> + 
> +-USELOC      = 1
> ++USELOC      = 0
> + LOC_FR      = fr
> + LOC_DE      = de
> + 
> + COLLATE     = 1
> + 
> +-PDF_COMPRESSION     = 0
> +-ZLIB                =
> ++PDF_COMPRESSION     = 1
> ++ZLIB                = -lz
> + ZLIBPATH    =
> + 
> + CC  = gcc

Are you sure that this port honours CC in mk.conf?  I'm just reading
your diff, not testing it so that's why I'm asking that question...

> + 
> + RCOPY       = cp -r
> + 
> +-COPTS       = -ansi -pedantic -Wall -O3
> ++#COPTS      = -ansi -pedantic -Wall -O3
> ++COPTS       = -O3

Is that -O3 flag safe?  Maybe it will cause problems on some weird
platforms?

> +@@ -336,10 +337,8 @@ prg2lout:       prg2lout.c
> + install: lout prg2lout
> +     @echo ""
> +     @echo "(a) Installing lout and prg2lout binaries into BINDIR $(BINDIR)"
> +-    cp lout $(BINDIR)/lout
> +-    chmod 755 $(BINDIR)/lout
> +-    cp prg2lout $(BINDIR)/prg2lout
> +-    chmod 755 $(BINDIR)/prg2lout
> ++    install -c -s -o root -g bin lout $(BINDIR)/lout
> ++    install -c -s -o root -g bin prg2lout $(BINDIR)/prg2lout

-s means strip the final binary, right?  So I guess that this port
doesn't honour INSTALL_STRIP.  Please use BSD_INSTALL_PROGRAM here (or
something like that; check bsd.port.mk manual)

> --- print/lout/Makefile.orig  Tue Jun  7 15:03:55 2005
> +++ print/lout/Makefile       Tue Jun  7 15:03:55 2005

Isn't that port a NO_REGRESS=Yes candidate?

Alek
-- 
Ale to nie jest bomba, a głowa strzelca obracająca się wokół osi, wyrzucająca
z wnętrza różową spiralę płynu lśniącego jaskrawo w świetle słońca. Wirniki
trafiły go wprost w szyję. D.U. składa się teraz z dwóch osób: jedna z nich
obojętnie patrzy na głowę obracającą się w pyle, druga wrzeszczy ile sił w
płucach.
 -- Neal Stephenson, Zamieć

Reply via email to