Robbert Haarman [Wed Jun 15, 2005 at 04:38:35PM +0200] wrote: >That sounds like a good idea. I checked for existing ports, but >didn't find any, that's why I made my own. Maybe you can send me >your ports so I can watch and learn? I'm still relatively new to >the ports system, especially the new features not in the porting >guide. > Tarball attached.
>> $ make lib-depends-check >> /usr/ports/packages/all/mpd-0.11.5.tgz: >> Missing: id3tag.3 (/usr/local/bin/mpd): NOT REACHABLE >> Missing: iconv.4 (/usr/local/bin/mpd): NOT REACHABLE >> Missing: mad.2 (/usr/local/bin/mpd): NOT REACHABLE > >I had not included these, because he mpd documentation does not >list these as dependencies. IIRC, mad and id3tag are included in >the distribution, so mpd will compile if these are not present on >the system. I was hoping to get some feedback on what would be the >best way to deal with this; my intuition says it's better to depend >on the external libraries and ignore the bundled ones. > I think to depend on the external libraries is the way to go. >I think I'll add a dependency on iconv, and move id3tag and mad in > To include iconv we use this: MODULES=converters/libiconv >an mp3 flavor, as I can see people not needing MP3 support. > In my port, I've enabled all supported codec. I think it's better to enable most of the supported codecs per default and put in some no_* FLAVORS. (like no_flac) But that's just my opinion. Comments? >> Missing system lib: c.37 (/usr/local/bin/mpd) > Missing system >lib: m.2 (/usr/local/bin/mpd) > Missing system lib: z.4 >(/usr/local/bin/mpd) > Missing system lib: pthread.6 (/usr/local/bin/mpd) > >These, I assume, would go in WANTLIB. As I understand it, WANTLIB >is for registering dependencies on libraries that are part of the >base system. I wonder why this was chosen over simply adding support >for this in LIB_DEPENDS. > WANTLIB is for base system libs and for libs that are reachable through LIB_DEPENDS. >Anyway, this leads me to another question: >how to determine the version of a library to depend on? I should >think my port doesn't need the very latest version of the C library, >but how do I know which version is new enough? > For the base libs you don't need to specify a version nuber. (WANTLIB= c z pthread) For the libs that are reachable through LIB_DEPENDS you are using the 'make lib-depends-check' output. Missing: ogg.5 from libogg-1.1.2 (/usr/local/bin/toc2mp3) (reachable through dependencies: WANTLIB) WANTLIB= c z pthread ogg.5 (If this is a false explanation, someone correct me please. :) ) Bernd
port-mpd.tgz
Description: application/tar-gz
