Antoine Jacoutot <[EMAIL PROTECTED]> wrote:
> Could a port guru have a look at the port and see what's missing for
> inclusion, please...
I'm not a port guru but here is what I would change:
a) there is no need to intl and iconv to WANTLIB as there already is
MODULES=devel/gettext
b) maybe FLAVOR can be replaced with SUBPACKAGE? Does it only add two
new files (those listed in PFRAG.shared-gphoto2)?
c) isn't gphoto FLAVOR SHARED_ONLY=Yes candidate? I mean, will it work
on architectures without shared libs?
d) as gphoto2_port comes with graphics/libgphoto2 it's better to use
something like this inside .if ${FLAVOR:L} == "gphoto2":
LIB_DEPENDS+= gphoto2,gphoto2_port::graphics/libgphoto2
CONFIGURE_ARGS+=--with-gphoto2
WANTLIB+= exif
e) Please use LOCALBASE instead of PREFIX in CONFIGURE_ARGS.
Alek
--
Włosy w odcieniu pięknego bogatego brązu, spięte w ryzykowny kok,
przytrzymywała szpilka, która mogła służyć za widelec do mięsa. Miała na sobie
suknie, która była chyba uszyta z juty. Dłonie, w których trzymała śpiewnik,
przypominały dwie kamienne płyty.
-- Stephen King, Roland
