On Thu, 22 Sep 2005 at 10:37 +0200, Aleksander Piotrowski wrote:
> Tim Kornau <[EMAIL PROTECTED]> wrote:
> 
> > this release has 5 flavors ( kerberos, net-snmp, mysql, pgsql, iodbc
> > ) it supports eap eap-tls eap-ttls and its cisco related
> > derivations.
> 
> - Flavors are not describet in pkg/DESCR

Fixed 

> - Don't hardcode /usr/local in Makefile.  Please use ${LOCALBASE} just
>   like you do it for pgsql FLAVOR

changed. Is there a smart Way to do the same for /usr ?

> - PKGNAME is not needed.

added pkgname for subpackages

> - Please remove an "a" from COMMENT

removed 

> - Use ${INSTALL_*} instead of @cp in pre-fake

changed @cp to ${INSTALL_DATA}

> - AMD64 is not valid ${MACHINE_ARCH}.  So please make it lower case or
>   use ${MACHINE_ARCH:U} if it works (;  BTW, isn't PIC also needed for
>   other arches (like sparc64 or macppc)?

I changed it to ${MACHINE_ARCH:U} if you can test on different
arches mail me if it fails ( we can also make this work on non
shared arches i think ).

> - Is following OK?  Make configure gives me this.
> 
> configure: warning: snmpget not found - Simultaneous-Use and checkrad.pl may 
> not work
> configure: warning: snmpwalk not found - Simultaneous-Use and checkrad.pl may 
> not work

This error will only arise if *-snmp is not installed on the
system. If users will have an installation without *-snmp they know
why and will have reasons for it. So the answer is YES it's OK in my
opinion. But as you suggested i switched the port to PSEUDO_FLAVORS
there for the Problem will go away anyway.

> 
> - Are you sure that you really want to install
>   ${WRKSRC}/raddb/dictionary.in and other *.in files?

I removed the .in Files.

> - BTW flavors only adds additional modules, no?  If this is true, then
>   please replace them with SUBPACKAGEs and PSEUDO_FLAVORs!
> 
Out of your next Mail

- And please fix WANTLIB markers!

done that with make lib-depends-check for all FLAVORS /
PSEUDOFLAVORS and without.

Attached is the new Port

Tim

-- 
Darksun rising over blood red sea

Attachment: freeradius-1.0.5_port.tgz
Description: application/tar-gz

Attachment: pgpyPas5AhMwh.pgp
Description: PGP signature

Reply via email to