On Sun, 2005-10-02 at 13:00 +0200, Aleksander Piotrowski wrote:
> Douglas Santos <[EMAIL PROTECTED]> wrote:
>
> > openct-0.6.6
>
> - don't hardcode /usr/local in Makefile (use ${LOCALBASE})
OK.
> - please check other ports and see if they have # Uses pthreads comment.
> Do they?
Some have..
# grep -r "Uses pthreads" *
audio/soundtracker/Makefile:# Uses pthreads
benchmarks/iozone/Makefile:# Uses pthreads
databases/mysql/Makefile:# Uses pthreads
devel/glib/Makefile:# Uses pthreads
devel/sdl/Makefile:# Uses pthreads
graphics/ggi/Makefile:# Uses pthreads
graphics/gii/Makefile:# Uses pthreads
lang/tcl/8.3/Makefile:# Uses pthreads (can but does not at the moment)
lang/tcl/8.4/Makefile:# Uses pthreads (can but does not at the moment)
net/mrtd/Makefile:# Uses pthreads
net/pdnsd/Makefile:# Uses pthreads
security/pcsc-lite/Makefile:# Uses pthreads
> - where is HOMEPAGE?
Added.
> - Missing: ltdl.4 (/usr/local/sbin/openct-control): NOT REACHABLE (make
> lib-depends-check). Hint: LIB_DEPENDS=ltdl.4::devel/libtool
OK.
> - please remove MESSAGE as it's really not needed and zap empty line
> from the end of pkg/DESCR
Done.
> > opensc-0.9.6
>
> - where is HOMEPAGE?
Added.
> - remove pkgconfig from you system and try to build opensc. See? It
> doesn't detect openct. Funny? Hint: Add pkgconfig to BUILD_DEPENDS
Oh, right.
> - pkg/MESSAGE is not needed
> - empty line at the end of pkg/DESCR
Done.
Thanks, diffs attached.
diff -ruN openct.orig/Makefile openct/Makefile
--- openct.orig/Makefile Sat Oct 1 14:31:11 2005
+++ openct/Makefile Sun Oct 2 20:46:18 2005
@@ -1,5 +1,4 @@
# $OpenBSD$
-# Uses pthreads
COMMENT= "implements drivers for several smart card readers"
@@ -7,6 +6,8 @@
CATEGORIES= security
+HOMEPAGE= http://www.opensc.org/openct
+
MAINTAINER= Douglas Santos <[EMAIL PROTECTED]>
# BSD
@@ -15,7 +16,9 @@
PERMIT_DISTFILES_CDROM= Yes
PERMIT_DISTFILES_FTP= Yes
-LIB_DEPENDS= usb::devel/libusb
+LIB_DEPENDS= usb::devel/libusb \
+ ltdl.4::devel/libtool
+
WANTLIB= c pthread
MASTER_SITES= http://www.opensc.org/files/
@@ -27,7 +30,7 @@
CONFIGURE_ARGS= ${CONFIGURE_SHARED} \
--enable-static \
--sysconfdir=${SYSCONFDIR} \
- --with-common-dir=/usr/local
+ --with-common-dir=${LOCALBASE}
CONFIGURE_ENV= PTHREAD_LIBS=-pthread
post-install:
diff -ruN openct.orig/pkg/DESCR openct/pkg/DESCR
--- openct.orig/pkg/DESCR Sat Oct 1 14:29:36 2005
+++ openct/pkg/DESCR Sun Oct 2 20:46:34 2005
@@ -13,4 +13,3 @@
* Aladdin eToken PRO
* Rainbow iKey 3000
* PertoSmart USB and Serial (ACS AC-1030)
-
diff -ruN openct.orig/pkg/MESSAGE openct/pkg/MESSAGE
--- openct.orig/pkg/MESSAGE Wed May 18 16:11:40 2005
+++ openct/pkg/MESSAGE Wed Dec 31 21:00:00 1969
@@ -1,3 +0,0 @@
-The openct configuration file have been installed into
-${SYSCONFDIR}/openct.conf.
-Please view this file and change the configuration to meet your needs.
diff -ruN opensc.orig/Makefile opensc/Makefile
--- opensc.orig/Makefile Sat Oct 1 14:31:49 2005
+++ opensc/Makefile Mon Oct 3 00:30:09 2005
@@ -1,5 +1,4 @@
# $OpenBSD$
-# Uses pthreads
COMMENT= "provides a set of libraries and utilities to access smart cards"
@@ -7,6 +6,8 @@
CATEGORIES= security
+HOMEPAGE= http://www.opensc.org
+
MAINTAINER= Douglas Santos <[EMAIL PROTECTED]>
# GPL
@@ -15,6 +16,7 @@
PERMIT_DISTFILES_CDROM= Yes
PERMIT_DISTFILES_FTP= Yes
+BUILD_DEPENDS= ::devel/pkgconfig
LIB_DEPENDS= openct::security/openct
WANTLIB= readline crypto termcap c pthread
diff -ruN opensc.orig/pkg/DESCR opensc/pkg/DESCR
--- opensc.orig/pkg/DESCR Sat Oct 1 14:33:21 2005
+++ opensc/pkg/DESCR Sun Oct 2 21:13:52 2005
@@ -5,4 +5,3 @@
so applications supporting this API such as Mozilla Firefox and
Thunderbird can use it. OpenSC implements the PKCS#15 standard and aims
to be compatible with every software that does so, too.
-
diff -ruN opensc.orig/pkg/MESSAGE opensc/pkg/MESSAGE
--- opensc.orig/pkg/MESSAGE Thu Aug 4 18:41:12 2005
+++ opensc/pkg/MESSAGE Wed Dec 31 21:00:00 1969
@@ -1,3 +0,0 @@
-Example configurations files have been installed
-in ${PREFIX}/share/examples/opensc
-and profiles in ${PREFIX}/share/opensc.
