Jacob Meuser <[EMAIL PROTECTED]> wrote:
> On Sat, Nov 19, 2005 at 10:09:21PM +0100, Michael Knudsen wrote:
>
> > I've attached an updated version in which I've fixed the tyop. Please
> > test and let me know how it works.
> >
> > Thanks for the feedback.
>
> hi,
>
> below is a patch for some issues/nits. I couldn't test operability
> because I don't have the data files.
>
> - get rid of the ${V} and use ${FOO:S///} constructs instead
> - lexically order WANTLIB
> - NO_CONFIGURE is deprecated ... it does nothing
> - add VERBOSE=1 to MAKE_ENV so the build commands are displayed
> - do a better job of respecting CFLAGS
> - make it possible to 'make clean' as a normal user after 'make fake'
> - missing header
> - NULL sentinel
> - settings.c and strgen/strgen.c gave warnings about 'cast from
> integer to pointer of different size' on amd64. patched to
> suppress those warnings, but this could be the wrong way to do it,
> particularly in settings.c.
Fine on amd64, but there are more problems with string functions as
pointed out in:
http://marc.theaimsgroup.com/?l=secunia-sec-adv&m=112599488304373&w=2
Martin
