On Tue, Jan 16, 2007 at 11:12:16AM +0100, Antoine Jacoutot wrote:
> On Tue, 16 Jan 2007, Antoine Jacoutot wrote:
> >This package adds perl support for Glade 2.x to Gtk2-Perl.
> 
> Use devel/gettext MODULE and regen PLIST.
well, set MODULES then instead of putting into WANTLIB, no?
and if you use MODULES=cpan, there's no need to set the 'perl5'
category.
also trimmed COMMENT a bit and put a '@' in the pre-configure target.

it looks good to me beside that.
--- Makefile.orig       Tue Jan 16 15:17:40 2007
+++ Makefile    Tue Jan 16 15:24:22 2007
@@ -2,11 +2,10 @@
 
 SHARED_ONLY=   Yes
 
-COMMENT=       "adds Perl support for Glade 2.x to Gtk2-Perl"
+COMMENT=       "Glade 2.x support for Gtk2-Perl"
 
 DISTNAME=      Gtk2-GladeXML-1.006
-PKGNAME=       p5-${DISTNAME}
-CATEGORIES=    x11 perl5
+CATEGORIES=    x11
 
 # GPLv2
 PERMIT_PACKAGE_CDROM=  Yes
@@ -16,10 +15,11 @@
 
 WANTLIB=       X11 Xext Xrender atk-1.0 cairo fontconfig freetype \
                gdk-x11-2.0 gdk_pixbuf-2.0 glib-2.0 glitz gmodule-2.0 \
-               gobject-2.0 gtk-x11-2.0 iconv intl m pango-1.0 \
-               pangocairo-1.0 pangoft2-1.0 png z
+               gobject-2.0 gtk-x11-2.0 m pango-1.0 pangocairo-1.0 \
+               pangoft2-1.0 png z
 
 MODULES=       cpan
+MODULES+=      devel/gettext
 
 USE_X11=       Yes
 
@@ -38,6 +38,6 @@
 REGRESS_FLAGS+=        DISPLAY=${DISPLAY} XAUTHORITY=${XAUTHORITY}
 
 pre-configure:
-       perl -pi -e 's,!!CFLAGS!!,${CFLAGS},g' ${WRKSRC}/Makefile.PL
+       @perl -pi -e 's,!!CFLAGS!!,${CFLAGS},g' ${WRKSRC}/Makefile.PL
 
 .include <bsd.port.mk>
> New tarball attached.
> 
> -- 
> Antoine



-- 
``This statement is false''
NedBSD: http://nedbsd.eu

Reply via email to