On 2020/10/27 20:36, Martin Reindl wrote: > In quick need for a recent python3-version of py-carbon I put together this > update diff > for py-whisper and py-carbon to 1.1.7 including quirks and conflict markers. > > It also goes straight from python2 to python3 so I'm not directly asking for > OKs but > would like to know if ports can go this path. Additional tests also welcome, > py-carbon > does not come with a test-suite but py-whisper does. The other thing is: > py-whisper > still pulls in python2 via rrdtool,-python. py-carbon depends on py-whisper > but both > ports don't have any other consumers. > > Comments? Am I missing something?
In general the py2-py3 moves look correct. > +RUN_DEPENDS = net/rrdtool,-python This can't work, it needs a python 3 version of the rrdtool bindings, this is in the separate pypi project "rrdtool". As things stand rrd2whisper will be broken. Port for that attached. OK to import? I have tested it by following "usage" on https://github.com/commx/python-rrdtool and checking produced rrd with "rrdtool dump". If that goes in, you can then change this to RUN_DEPENDS=net/py-rrdtool${MODPY_FLAVOR} and rrd2whisper.py should work again. I would put it in databases/, but rrdtool itself is already in net/ (which I consider the wrong subdirectory), so I'll just follow along with that otherwise things get even more confusing :) > @@ -108,3 +119,13 @@ share/examples/graphite/whitelist.conf.e > @sample /var/graphite/storage/whisper/ > @owner > @group > +storage/ > +storage/ceres/ > +storage/ceres/dummy.txt/ > +storage/lists/ > +storage/log/ > +storage/log/dummy.txt/ > +storage/rrd/ > +storage/rrd/dummy.txt/ > +storage/whisper/ > +storage/whisper/dummy.txt/ These files in /usr/local/storage seem wrong.
