On 2020/10/30 20:08, Grégoire Jadi wrote:
> Hi,
>
> Here is a draft to update mnemosyne to 2.7.2 (latest). I am using it as
> desktop app, webserver and syncserver successfully; it also sync with
> the Android application properly.
>
> This port is currently in games/mnemosyne. Would it be possible to move
> it under education/mnemosyne? What's the process to do that?
Moving it loses cvs history (and, though it doesn't apply here, for
ports which others depend on means that we have to update all those
other ports too). As a result we generally do not move ports between
directories. (And it doesn't matter for packages anyway, mnemosyne is
already listed in both games and education).
> Also, I disabled the google integration because it requires gTTS and
> googletrans which aren't in the ports (yet?).
>
> What's the correct approach here? Should I port the missing deps?
> Should I work with upstream to have an option to disable google
> integration?
Disabling it for now seems a reasonable approach. Either porting the
deps, or working with upstream to make them optional, would be more
convenient for future updates than maintaining a patch to disable
them, but as long as the patch is not too complicated then patching
is fairly OK too.
> +# XXX From anki/Makefile. Is it needed?
> +# build needs some of the py-qt5 tools; pull them in via
> +# py-qtwebengine so that build fails early on arches where
> +# qtwebengine isn't available
> +BUILD_DEPENDS = www/py-qtwebengine${MODPY_FLAVOR}
I think that's reasonable.
Looking at the *existing* dependencies on mnemosyne there are some
problems.
RUN_DEPENDS= x11/py-qt5,python3 \
textproc/py-xml \
graphics/py-Pillow,python3 \
graphics/py-matplotlib,python3 \
www/py-cheroot,python3 \
www/py-webob,python3>=1.3.1 \
www/py-qtwebengine \
devel/desktop-file-utils
1. the "foo,python3" entries should be replaced by "foo${MODPY_FLAVOR}"
2. www/py-qtwebengine should have ${MODPY_FLAVOR} added
3. textproc/py-xml can't be doing anything useful here, the py-xml port
does not have a py3 version
