On Mon, Dec 14, 2020 at 02:44:29AM -0500, Brad Smith wrote:
> Here is an update to mpv 0.33.0.
>
> Any testing would be appreciated.
>
Hi Brad,
Thanks for updating it. I noticed some issues.
>
> Index: Makefile
> ===================================================================
> RCS file: /home/cvs/ports/multimedia/mpv/Makefile,v
> retrieving revision 1.65
> diff -u -p -u -p -r1.65 Makefile
> --- Makefile 10 Nov 2020 16:40:18 -0000 1.65
> +++ Makefile 22 Nov 2020 21:48:18 -0000
> @@ -4,10 +4,9 @@ COMMENT = movie player based on MPlayer
>
> GH_ACCOUNT = mpv-player
> GH_PROJECT = mpv
> -GH_TAGNAME = v0.32.0
> -REVISION = 2
> +GH_TAGNAME = v0.33.0
>
> -SHARED_LIBS += mpv 0.1 # 1.107
> +SHARED_LIBS += mpv 0.2 # 1.107
>
> CATEGORIES = multimedia x11
>
> @@ -26,7 +25,7 @@ WANTLIB += Xinerama Xrandr Xrender Xss X
> WANTLIB += avcodec avdevice avfilter avformat avresample avutil
> WANTLIB += bluray c cdio cdio_cdda cdio_paranoia drm dvdnav dvdread
> WANTLIB += epoxy expat fontconfig freetype fribidi gbm iconv jpeg
> -WANTLIB += lcms2 lua5.1 m placebo postproc pthread sndio swresample
> +WANTLIB += lcms2 lua5.1 m placebo postproc pthread swresample
> WANTLIB += swscale xcb xcb-dri2 xcb-glx xml2 z
>
> MODULES = lang/lua \
> @@ -66,7 +65,6 @@ CONFIGURE_ARGS = --confloaddir=${SYSCONF
> --enable-cdda \
> --enable-dvdnav \
> --enable-libmpv-shared \
> - --enable-sndio \
> --enable-sdl2 \
> --disable-alsa \
> --disable-caca \
> @@ -75,12 +73,10 @@ CONFIGURE_ARGS = --confloaddir=${SYSCONF
> --disable-gl-wayland \
> --disable-jack \
> --disable-rubberband \
> - --disable-oss-audio \
> --disable-openal \
> --disable-optimize \
> --disable-pulse \
> - --disable-rsound \
> - --disable-libsmbclient \
> + --disable-sixel \
> --disable-uchardet \
> --disable-vaapi \
> --disable-vaapi-drm \
> Index: distinfo
> ===================================================================
> RCS file: /home/cvs/ports/multimedia/mpv/distinfo,v
> retrieving revision 1.24
> diff -u -p -u -p -r1.24 distinfo
> --- distinfo 29 Oct 2020 13:44:14 -0000 1.24
> +++ distinfo 22 Nov 2020 20:32:07 -0000
> @@ -1,4 +1,4 @@
> -SHA256 (mpv-0.32.0.tar.gz) = kWP2SDIibSLiS7xIdOvWrAI3LNcXvvFcKKCqhYxf5ZI=
> +SHA256 (mpv-0.33.0.tar.gz) = 8bm69dwu6vN2WXwopigfrPbtmP89Vn45Vclb8kWVILQ=
> SHA256 (waf-2.0.20) = v5cemO3CQUloomLGqmuIVBomw80khonIn0xXNwlV7n8=
> -SIZE (mpv-0.32.0.tar.gz) = 3148730
> +SIZE (mpv-0.33.0.tar.gz) = 3259387
> SIZE (waf-2.0.20) = 104725
> Index: patches/patch-libmpv_client_h
> ===================================================================
> RCS file: /home/cvs/ports/multimedia/mpv/patches/patch-libmpv_client_h,v
> retrieving revision 1.5
> diff -u -p -u -p -r1.5 patch-libmpv_client_h
> --- patches/patch-libmpv_client_h 29 Jan 2020 06:52:21 -0000 1.5
> +++ patches/patch-libmpv_client_h 22 Nov 2020 21:06:48 -0000
> @@ -5,11 +5,11 @@ Set shared library version.
> Index: libmpv/client.h
> --- libmpv/client.h.orig
> +++ libmpv/client.h
> -@@ -229,7 +229,7 @@ extern "C" {
> +@@ -235,7 +235,7 @@ extern "C" {
> * relational operators (<, >, <=, >=).
> */
> #define MPV_MAKE_VERSION(major, minor) (((major) << 16) | (minor) | 0UL)
> --#define MPV_CLIENT_API_VERSION MPV_MAKE_VERSION(1, 107)
> +-#define MPV_CLIENT_API_VERSION MPV_MAKE_VERSION(1, 109)
> +#define MPV_CLIENT_API_VERSION MPV_MAKE_VERSION(${LMAJ}, ${LMIN})
>
> /**
> Index: pkg/PLIST
> ===================================================================
> RCS file: /home/cvs/ports/multimedia/mpv/pkg/PLIST,v
> retrieving revision 1.9
> diff -u -p -u -p -r1.9 PLIST
> --- pkg/PLIST 29 Jan 2020 06:52:21 -0000 1.9
> +++ pkg/PLIST 22 Nov 2020 21:11:12 -0000
> @@ -3,7 +3,6 @@
> include/mpv/
> include/mpv/client.h
> include/mpv/opengl_cb.h
> -include/mpv/qthelper.hpp
> include/mpv/render.h
> include/mpv/render_gl.h
> include/mpv/stream_cb.h
> @@ -20,6 +19,7 @@ share/examples/mpv/mpv.conf
> share/examples/mpv/mpv_identify.sh
> share/examples/mpv/restore-old-bindings.conf
> share/examples/mpv/umpv
> +share/icons/hicolor/128x128/apps/mpv.png
> share/icons/hicolor/16x16/apps/mpv.png
> share/icons/hicolor/32x32/apps/mpv.png
> share/icons/hicolor/64x64/apps/mpv.png
>
~/music $ mpv somefile.opus
(+) Audio --aid=1 --alang=eng (opus 2ch 48000Hz)
[ao] Audio output sndio not found!
[ao] Failed to initialize audio driver 'sndio'
Could not open/initialize audio device -> no sound.
Audio: no audio
Segmentation fault (core dumped)
Theres no sound. I read sndio support was removed from upstream mpv. This also
affects some Linux distros such as Oasis Linux which use sndio.
https://github.com/mpv-player/mpv/issues/7236
If configuration changes are now required to make sound working they should
probably be documented in the pkg-readmes.
The segmentation fault is a known threading issue, but has also not been fixed
yet on OpenBSD.
--
Kind regards,
Hiltjo
