On 2021/01/11 12:30, Gerald Chudyk wrote:
> On Mon, Jan 11, 2021 at 12:08 PM Stuart Henderson <[email protected]>
> wrote:
> >
> > On 2021/01/11 12:04, Gerald Chudyk wrote:
> > > Index: lang/gnucobol/Makefile
> > > ===================================================================
> > > RCS file: /cvs/ports/lang/gnucobol/Makefile,v
> > > retrieving revision 1.7
> > > diff -u -p -u -r1.7 Makefile
> > > --- lang/gnucobol/Makefile 27 Dec 2020 16:54:11 -0000 1.7
> > > +++ lang/gnucobol/Makefile 11 Jan 2021 19:58:48 -0000
> > > @@ -8,7 +8,7 @@ SHARED_LIBS += cob 5.0 # 5.0
> > >
> > > CATEGORIES = lang
> > >
> > > -HOMEPAGE = http://www.opencobol.org/
> > > +HOMEPAGE = http://www.gnu.org/software/gnucobol/
> > >
> > > # compiler: GPLv3+
> > > # run-time library: LGPLv3+
> > >
> >
> > It just redirects to https://gnucobol.sourceforge.io/, I'll update it
> > to that instead.
>
> I submitted this change at the request of Simon, one of the gnucobol
> developers. They have been working at changing upstream to install as
> clean as possible on openbsd and asked me a few questions that will
> take me a long time to understand and answer. If you don't mind a
> punt, here is what he is asking:
>
> > Can you please check with fcambus for the following points?
> >
> > 1 fix the homepage
> > https://www.gnu.org/software/gnucobol/
>
> OK, we did that.
>
> >
> > 2 BUILD_DEPENDS - makeinfo should not be invoked at all if it isn't
> > manually triggered in the OpenBSD build process
This happens for two reasons;
firstly, because configure is patched and therefore has an updated
timestamp, this triggers updates (stamp-vti depends on configure in
doc/Makefile).
secondly, if we avoid patching configure, the files in the distfile
are timestamped in the wrong order:
$ ls -lT doc/{version.texi,stamp-vti,gnucobol.info}
-rw-r--r-- 1 _pbuild _pbuild 189740 Dec 23 10:52:59 2020 doc/gnucobol.info
-rw-r--r-- 1 _pbuild _pbuild 101 Dec 23 12:04:58 2020 doc/stamp-vti
-rw-r--r-- 1 _pbuild _pbuild 101 Dec 23 10:52:58 2020 doc/version.texi
excerpt from make -dm:
Examining ./stamp-vti...modified 12:04:58.000000000 Dec 23, 2020...up-to-date.
Examining ./version.texi...modified 10:52:58.000000000 Dec 23, 2020...modified
before source(./stamp-vti)...out-of-date.
update time: 12:04:58.000000000 Dec 23, 2020
[...]
Examining ./gnucobol.info...modified 10:52:59.000000000 Dec 23, 2020...modified
before source(./version.texi)...out-of-date.
> > 3 configure patch: if makeinfo is needed it should be possible to pass it
> > via CONFIGURE_ENV - if this doesn't work we would integrate a patch for
> > that :-)
Yes (as expected) that works too.
> > 4 that looks special, what does
> > echo "-$OSTYPE-"
> > return in OpenBS (or any BSD)?
> > If there's something useful in it we can add this to the "upstream" sources
I don't know gnucobol at all and not sure what that patch is doing,
perhaps it was needed in an earlier version. $OSTYPE is an unportable
bashism, it is not set in the standard shell on OpenBSD.
