James Cook <[email protected]> writes:
> Thanks. I split up the long command and removed quotes:
>
> https://github.com/falsifian/ports/commit/e24278e3c1d7fca1b3c4961a0e81a5bb2ca5bcf0

I pushed my update: 
https://github.com/blackgnezdo/ports/commit/83db945f59633c848a9ae28627cd8e378e316a09

> Two notes:
>
> * Currently "make post-build" fails if you run it twice. Adding -p in
>   "mkdir ${MAN1_STAGING_DIR}" would fix that. I don't know if it's
>   better to fail or not if "make post-build" gets run more than once.

It seems unusual for `make rebuild` to fail. Your newly added action is
idempotent.

> * I see you put "@" before the ln -s lines. I wasn't sure whether to
>   add them to the other commands. The output is not that interesting.

I added them to your commands as I agree the output is not interesting.

> I confirmed the port works by installing on a different machine.

Thank you for testing this!

> One hitch: I needed to manually uninstall the current cabal-install
> port because it conflicts with the new cabal port. Is there a way to
> tell ports that cabal is a successor to cabal-install?

Yes, we'll need to update the quirks package which provides transitions
for this kind of cases.

> (I considered putting the man-building commands in post-install, but I
> wasn't sure where to put the staging directory if I did that. I wanted
> the staging directory because I assumed I should use the ${INSTALL_MAN}
> macro if possible to put the files in their final place.)

I think what we have now is fine.

>> I'll dig into this a bit. I simply didn't need to worry about this up
>> until now as all the other ports don't do much custom Setup.hs work.
>
> I don't know if there will be any cases other than man pages and
> git-annex's command aliases. Not sure how much effort it's worth.

The default action of doing nothing is valid :)

Thanks
Greg

Reply via email to