On 2021/02/08 10:44, Evandro Rathke wrote:
> Hi folks!
> I hope everyone is going well.
>
> This is the port for Ultimaker Cura. It's an update for the latest stable
> version (4.8.0) available.
> More info: https://gitlab.com/erathke/cura-port
quick comments;
~20 ports in one go is too many to review, please split off the standalone
ones and handle them first.
FLAVORS=python3 is only for "library" ports with pkgnames like py-XXX,
for things like cad/ultimaker/cura the way to set this is with
MODPY_VERSION=${MODPY_DEFAULT_VERSION_3}
please don't hide FLAVORS=python3 at the bottom of files, put it up
a bit higher near MODULES=lang/python where it's more obvious.
deps on math/py-networkx math/py-triangle x11/py-pyglet don't
have ${MODPY_FLAVOR}. the math/py-triangle port doesn't even have
a py3 version?
suggest not splitting cad/ultimaker and net/ultimaker, just put the
ultimaker-specific net libs under cad/ultimaker.
consider adding a file cad/ultimaker/Makefile.inc and factor out some
common parts (even just a few things like setting the version of the
various ultimaker ports in a common place since they all seem to be
tied together in updates).
