On Tuesday, February 9th, 2021 at 11:19 PM, Greg Steuck <[email protected]> wrote:
> Brian Callahan [email protected] writes: > > > Hi ports -- > > > > This diff fixes gophernicus with -fno-common. > > > > I didn't update it since upstream has a new and broken build process. > > > > Also drop myself as maintainer. > > > > OK? > > The patch reads OK but I don't understand why these would get declared > > given the statement that we don't have libwrap? > At the beginning of the build, gophernicus does this: echo "/* Automatically generated function definitions */" > functions.h echo >> functions.h grep -h "^[a-z]" gophernicus.c file.c menu.c string.c platform.c session.c options.c | grep -v "int main" | grep -v "strlc" | grep -v "[a-z]:" | sed -e "s/ =.*$//" -e "s/ *$/;/" >> functions.h This unconditionally sticks an int allow_severity; int deny_serverity; in functions.h, which gets pulled into multiple C files. ~Brian > > ~Brian > > > > Index: Makefile > > =============== > > > > RCS file: /cvs/ports/net/gophernicus/Makefile,v > > > > retrieving revision 1.19 > > > > diff -u -p -r1.19 Makefile > > > > --- Makefile 6 Feb 2020 18:06:10 -0000 1.19 > > > > +++ Makefile 10 Feb 2021 01:57:11 -0000 > > > > @@ -1,6 +1,7 @@ > > > > $OpenBSD: Makefile,v 1.19 2020/02/06 18:06:10 edd Exp $ > > ======================================================= > > > > COMMENT= modern gopher server > > > > +REVISION = 0 > > > > GH_ACCOUNT= gophernicus > > > > GH_PROJECT= gophernicus > > > > @@ -9,8 +10,6 @@ GH_TAGNAME= v3.0.1 > > > > CATEGORIES= net > > > > HOMEPAGE= gopher://gophernicus.org/ > > ----------------------------------- > > > > -MAINTAINER = Brian Callahan [email protected] > > > > BSD > > === > > > > PERMIT_PACKAGE= Yes > > > > Index: patches/patch-gophernicus_c > > ======================================================= > > > > RCS file: patches/patch-gophernicus_c > > > > diff -N patches/patch-gophernicus_c > > > > --- /dev/null 1 Jan 1970 00:00:00 -0000 > > > > +++ patches/patch-gophernicus_c 10 Feb 2021 01:57:11 -0000 > > > > @@ -0,0 +1,16 @@ > > > > +$OpenBSD$ > > > > + > > > > +We don't have libwrap, and these cause issues with -fno-common > > > > + > > > > +Index: gophernicus.c > > > > +--- gophernicus.c.orig > > > > ++++ gophernicus.c > > > > +@@ -30,8 +30,6 @@ > > > > - - Libwrap needs these defined > > - */ > > - #ifdef HAVE_LIBWRAP > > > > +-int allow_severity = LOG_DEBUG; > > > > +-int deny_severity = LOG_ERR; > > - #endif
