Oh the xxCONFIGURE_ARGS should just be removed, it was from testing. The dependencies are not needed unless those args are set. With a git checkout they are needed in order to generate docs but with a released tarball they are not.

--
 Sent from a phone, apologies for poor formatting.
On 13 February 2021 06:03:54 Rafael Sadowski <raf...@sizeofvoid.org> wrote:

On Fri Feb 12, 2021 at 11:16:32PM +0000, Stuart Henderson wrote:
On 2021/02/12 09:29, Guy Godfroy wrote:
> I ended up by almost duplicating i3-mousedrag. So now i3-sensible-*
> stuff are back in the game.
>
> Let me know what you think about it.

thanks, some of the diff didn't apply but I have got it into shape,
and adapted a few things (some parts only relevant for builds from
git which isn't needed for proper releases) and committed.

it looks like the upstream ticket with i3-mousedrag is moving again,
so I'm hoping that we'll be able to get rid of i3-mousedrag and
merge into the main port before too long, so it's good to have things
in sync.


Looks like xxCONFIGURE_ARGS is a mistake and it hides build
dependencies.

Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/i3/Makefile,v
retrieving revision 1.127
diff -u -p -u -p -r1.127 Makefile
--- Makefile    12 Feb 2021 23:14:04 -0000      1.127
+++ Makefile    13 Feb 2021 05:55:21 -0000
@@ -3,6 +3,7 @@
COMMENT =       improved dynamic tiling window manager

DISTNAME =      i3-4.19.1
+REVISION =     0

CATEGORIES =    x11

@@ -36,13 +37,15 @@ RUN_DEPENDS =       devel/desktop-file-utils \
                x11/dmenu \
                x11/i3status \
                x11/p5-AnyEvent-I3
+BUILD_DEPENDS =        textproc/asciidoc \
+               textproc/xmlto
MODULES =       devel/meson

# Tests now use the X11::XCB Perl module, not yet in ports and a bit complex
#TEST_DEPENDS=  x11/p5-AnyEvent-I3
NO_TEST=        Yes

-xxCONFIGURE_ARGS=      -Dmans=true \
+CONFIGURE_ARGS=        -Dmans=true \
                -Ddocs=true
CONFIGURE_ENV=  CPPFLAGS="-I${X11BASE}/include -I${LOCALBASE}/include" \
                LDFLAGS="-L${X11BASE}/lib -L${LOCALBASE}/lib"

Reply via email to