On Sun, Feb 14, 2021 at 05:28:13PM +0000, Brian Callahan wrote: > Hi ports -- > > Attached is a diff to fix editors/hexcurse with -fno-common. > It is taken from Debian: > https://sources.debian.org/data/main/h/hexcurse/1.58-1.3/debian/patches/gcc-10.patch > > While here, remove -Werror to avoid future surprises. > > OK? > > ~Brian
ok tb with one comment below. > Index: patches/patch-src_file_c > =================================================================== > RCS file: patches/patch-src_file_c > diff -N patches/patch-src_file_c > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ patches/patch-src_file_c 14 Feb 2021 17:26:20 -0000 > @@ -0,0 +1,17 @@ > +$OpenBSD$ > + > +-fno-common fixes from Debian > +https://sources.debian.org/data/main/h/hexcurse/1.58-1.3/debian/patches/gcc-10.patch > + > +Index: src/file.c > +--- src/file.c.orig > ++++ src/file.c > +@@ -18,6 +18,8 @@ > + > \******************************************************************************/ > + #include "hex.h" > + > ++FILE *fpIN, *fpOUT; No need to add fpOUT here. Unused outside of src/llist.c where it is already defined. If you drop it the fix effectively becomes Gentoo's patch which is also an open PR: https://github.com/LonnyGomes/hexcurse/pull/28 So I'd update the comments from debian to that. > ++ > + /*******************************************************\ > + * Description: prints out a line of text to the screen* > + * the current address line and both the * >
