Thanks Chris, and thanks for the "variations" I can see where you were taking a scalpel out where I had used the sledge hammer :)
Appreciate you accepting and improving the patches All the best Tom Smyth On Wed, 14 Apr 2021 at 21:08, Chris Cappuccio <[email protected]> wrote: > > I've got all of your changes (or variations thereof) in the github repository, > except for the version number change since it isn't quite time to bump yet. > > Time to work on the known issues and expand compatibilty with the many > features > added in the last 3 or 4 years :) > > Tom Smyth [[email protected]] wrote: > > Hello, > > > > Please find attached patch for nsh > > > > feedback welcome as my C is rusty, > > > > I hope this helps, > > > > details of proposed patch outlined below > > > > > > Architectures Compiled on: > > AMD64 > > > > Compile errors / warnings > > 1) warning about an unused variable do not want to delete code just yet > > 2) errors about '\0' Null pointers cleared > > 3) fixed compatibility with OpenBSD Current and tried to maintain backward > > compatibility with release (using #ifdef (March 11 commit in base > > for IFXF_INET6_NOPRIVACY depreciated and replaced with IFXF_AUTOCONF6TEMP > > 4) fixed warning about self assigned variable with (void)ch; > > > > Tested: > > Manually tested on 6.9 beta current April 11 amd64 > > > > BUGS Resolved: > > show version fixed as there was a sysctl incompatibility that > > was throwing an error when "show version" command was run > > > > Known Issues: > > sysctl commands / functions need to be updated in line with changes in base > > new interfaces to be added > > arptimeout command is not working > > > > Enhancements: > > increased the verbosity of the version displayed when running NSH > > so it is easier for the user to see the version and patch level. > > > > > > My sincere thanks to Chris Cappuccio for authoring and opensourcing NSH. > > -- Kindest regards, Tom Smyth.
