Please consider a nit noted below.
Rafael Sadowski <[email protected]> writes:
> On Tue Apr 06, 2021 at 07:28:42AM +0200, Rafael Sadowski wrote:
>> I try to update knockpy to 5.0.0. Does anyone have a clue why knockpy 5
>> can't find bs4 aka beautifulsoup4?
>>
>
> I pointed out a bogus requirement entry in setup.py. In the meantime,
> upstream has also noticed it and fixed it in the next release.
>
> New 5.1.0 version with new dependencies.
>
> OK?
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/security/knockpy/Makefile,v
> retrieving revision 1.6
> diff -u -p -u -p -r1.6 Makefile
> --- Makefile 23 Feb 2021 19:39:38 -0000 1.6
> +++ Makefile 18 Apr 2021 19:57:33 -0000
> @@ -2,15 +2,14 @@
>
> COMMENT = subdomain scanner
>
> -MODPY_EGG_VERSION = 4.1
> -VERSION = 4.1.0
> -REVISION = 0
> +VERSION = 5.1.0
> +MODPY_EGG_VERSION = 5.1
>
> DISTNAME = knockpy-${VERSION}
>
> GH_ACCOUNT = guelfoweb
> GH_PROJECT = knock
> -GH_TAGNAME = ${VERSION}
> +GH_TAGNAME = ${VERSION}
>
> CATEGORIES = security
>
> @@ -20,15 +19,14 @@ MAINTAINER = Rafael Sadowski <rsadowski@
> PERMIT_PACKAGE= Yes
>
> MODULES = lang/python
> -MODPY_VERSION = ${MODPY_DEFAULT_VERSION_2}
>
> MODPY_SETUPTOOLS = Yes
>
> -RUN_DEPENDS = net/py2-dnspython
> -
> -fix-plist: plist
> - sed -i \
> - 's,site-packages/knock$${MODPY_PY_PREFIX},site-packages/knockpy-,' \
> - ${PKGDIR}/PLIST
> +RUN_DEPENDS = devel/py-colorama${MODPY_FLAVOR} \
> + graphics/py-matplotlib${MODPY_FLAVOR} \
> + math/py-networkx${MODPY_FLAVOR} \
> + www/py-beautifulsoup4${MODPY_FLAVOR} \
> + www/py-requests${MODPY_FLAVOR} \
> + x11/py-qt5${MODPY_FLAVOR}
>
> .include <bsd.port.mk>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/security/knockpy/distinfo,v
> retrieving revision 1.3
> diff -u -p -u -p -r1.3 distinfo
> --- distinfo 3 Nov 2017 21:22:02 -0000 1.3
> +++ distinfo 18 Apr 2021 19:57:33 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (knockpy-4.1.0.tar.gz) = PTeM5IK88LpXrOZemdzEduld6ZMO9uAaXsJZQlI9Ypw=
> -SIZE (knockpy-4.1.0.tar.gz) = 14197
> +SHA256 (knockpy-5.1.0.tar.gz) = 0RO27pgZIqa6aOk3KWew/zQQESxUy8E/h9z4QxI6Es8=
> +SIZE (knockpy-5.1.0.tar.gz) = 27829
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/security/knockpy/pkg/PLIST,v
> retrieving revision 1.3
> diff -u -p -u -p -r1.3 PLIST
> --- pkg/PLIST 3 Nov 2017 21:22:02 -0000 1.3
> +++ pkg/PLIST 18 Apr 2021 19:57:33 -0000
> @@ -1,31 +1,17 @@
> @comment $OpenBSD: PLIST,v 1.3 2017/11/03 21:22:02 rsadowski Exp $
> bin/knockpy
> lib/python${MODPY_VERSION}/site-packages/knockpy/
> -lib/python${MODPY_VERSION}/site-packages/knockpy-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/
> -lib/python${MODPY_VERSION}/site-packages/knockpy-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/PKG-INFO
> -lib/python${MODPY_VERSION}/site-packages/knockpy-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/SOURCES.txt
> -lib/python${MODPY_VERSION}/site-packages/knockpy-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/dependency_links.txt
> -lib/python${MODPY_VERSION}/site-packages/knockpy-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/entry_points.txt
> -lib/python${MODPY_VERSION}/site-packages/knockpy-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/requires.txt
> -lib/python${MODPY_VERSION}/site-packages/knockpy-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/top_level.txt
> +lib/python${MODPY_VERSION}/site-packages/knockpy-5.1.0-py${MODPY_VERSION}.egg-info/
> +lib/python${MODPY_VERSION}/site-packages/knockpy-5.1.0-py${MODPY_VERSION}.egg-info/PKG-INFO
> +lib/python${MODPY_VERSION}/site-packages/knockpy-5.1.0-py${MODPY_VERSION}.egg-info/SOURCES.txt
> +lib/python${MODPY_VERSION}/site-packages/knockpy-5.1.0-py${MODPY_VERSION}.egg-info/dependency_links.txt
> +lib/python${MODPY_VERSION}/site-packages/knockpy-5.1.0-py${MODPY_VERSION}.egg-info/entry_points.txt
> +lib/python${MODPY_VERSION}/site-packages/knockpy-5.1.0-py${MODPY_VERSION}.egg-info/requires.txt
> +lib/python${MODPY_VERSION}/site-packages/knockpy-5.1.0-py${MODPY_VERSION}.egg-info/top_level.txt
Should 5.1.0 be ${VERSION}?
> lib/python${MODPY_VERSION}/site-packages/knockpy/__init__.py
> -lib/python${MODPY_VERSION}/site-packages/knockpy/__init__.pyc
> +${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/knockpy/${MODPY_PYCACHE}/
> +lib/python${MODPY_VERSION}/site-packages/knockpy/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
> +lib/python${MODPY_VERSION}/site-packages/knockpy/${MODPY_PYCACHE}knockpy.${MODPY_PYC_MAGIC_TAG}pyc
> +lib/python${MODPY_VERSION}/site-packages/knockpy/config.json
> lib/python${MODPY_VERSION}/site-packages/knockpy/knockpy.py
> -lib/python${MODPY_VERSION}/site-packages/knockpy/knockpy.pyc
> -lib/python${MODPY_VERSION}/site-packages/knockpy/modules/
> -lib/python${MODPY_VERSION}/site-packages/knockpy/modules/__init__.py
> -lib/python${MODPY_VERSION}/site-packages/knockpy/modules/__init__.pyc
> -lib/python${MODPY_VERSION}/site-packages/knockpy/modules/header.py
> -lib/python${MODPY_VERSION}/site-packages/knockpy/modules/header.pyc
> -lib/python${MODPY_VERSION}/site-packages/knockpy/modules/resolve.py
> -lib/python${MODPY_VERSION}/site-packages/knockpy/modules/resolve.pyc
> -lib/python${MODPY_VERSION}/site-packages/knockpy/modules/save_report.py
> -lib/python${MODPY_VERSION}/site-packages/knockpy/modules/save_report.pyc
> -lib/python${MODPY_VERSION}/site-packages/knockpy/modules/virustotal_subdomains.py
> -lib/python${MODPY_VERSION}/site-packages/knockpy/modules/virustotal_subdomains.pyc
> -lib/python${MODPY_VERSION}/site-packages/knockpy/modules/wildcard.py
> -lib/python${MODPY_VERSION}/site-packages/knockpy/modules/wildcard.pyc
> -lib/python${MODPY_VERSION}/site-packages/knockpy/modules/zonetransfer.py
> -lib/python${MODPY_VERSION}/site-packages/knockpy/modules/zonetransfer.pyc
> -lib/python${MODPY_VERSION}/site-packages/knockpy/wordlist/
> -lib/python${MODPY_VERSION}/site-packages/knockpy/wordlist/wordlist.txt
> +lib/python${MODPY_VERSION}/site-packages/knockpy/wordlist.txt