On 5 July, Theo Buehler wrote: > Some simple runtime testing indicates that it works fine on sparc64. > 'make test' succeeds on both amd64 and sparc64.
Thanks for testing!
> The first line of the Makefile should be '# $OpenBSD$', followed by an
> empty line. This tag will be expanded by cvs on commit (see keyword
> substitution in rcs(1) for details).
>
> For pkg/PLIST, generate it using 'make update-plist'. It will add
> '@comment $OpenBSD: PLIST,v$' as a first line to what you did manually.
Done and done (attached). Hopefully the overlong line is acceptable
too, seeing as it’s all generated by cargo-module(5) anyway?
> Regarding unveil: with pledge dns, a number of files are made available
> by the BYPASSUNVEIL mechanism (see /usr/src/sys/kern/kern_pledge.c):
> /* DNS needs /etc/{resolv.conf,hosts,services,protocols}. */
> so I think it would be sufficient if you removed all filesystem access
> via 'expect_unveil("", "");' (I haven't tested this).
Good to know! I’ll play around with this before the next release.
> I'm unsure if 'MODCARGO_RUSTFLAGS = -C debuginfo=0' is desirable, but
> I don't know if/how cargo.port.mk handles debug packages.
I looked into this, and apparently I didn’t need it. Not only did bore
use the default of [profile.release] debug=false [0] (unlike ripgrep),
but CONFIGURE_STYLE=cargo effectively overrides it to false anyway.
[0] https://doc.rust-lang.org/cargo/reference/profiles.html#release
For reference, here’s what I’ve changed:
https://bitbucket.org/delan/nonymous/commits/2596ed9455d80
bore.tar
Description: Binary data
