On Wed, Jul 07 2021, Kinichiro Inoguchi <[email protected]> wrote: > This is update for sunclock 3.57. > > - remove REVISION for the first revision of 3.57. > - change MASTER_SITES to github.
This looks better than what I had, at least because my stubborn diff was using GH_PROJECT/GH_COMMIT/etc instead of using a standalone mirror. https://pbot.rmdir.de/_sNK4DwEWIutWVkColzqqg for reference, though I don't suggest using it. > +MASTER_SITES= > https://raw.githubusercontent.com/nongiach/Sunclock/master/ > +MASTER_SITES0= > https://raw.githubusercontent.com/nongiach/Sunclock/master/ ^^^^^^ Since those URLs embed a reference to the "master" branch they aren't stable. Using the commit hash instead of "master" works and should be reasonably stable. Also, as noted by sthen@ no need for two MASTER_SITES lines. > - remove Xext, Xau and Xdmcp from WANTLIB-main > - remove Sunclock.se from PLIST-main since 3.57 drops it Please run ''make plist'', the file has been renamed to Sunclock.sv. > HOMEPAGE appears to be unreachable, but I left it as is > since I couldn't find better alternative. I agree with sthen: no need to keep the old HOMEPAGE. Overall, your changes look good but please address the issue mentioned above. One thing that was not clear to me was the -maps distfiles handling: if they bear no license, should we mirror them? (And If it's ok to mirror them - I don't say it is - then surely we could also redistribute those original files as part of the -maps subpackage?) -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
