Hi,

The loading spinner in trojita is misbehaving on my macppc machine.

Upstream has already dealt with the situation [0], and after applying
their patch the spinner is fine on macppc. There is indeed no
regression on amd64.

OK?

Charlène.


[0]
https://github.com/KDE/trojita/commit/e4478df9389894b6498ffe252310cdecd1e58904


Index: Makefile
===================================================================
RCS file: /cvs/ports/mail/trojita/Makefile,v
retrieving revision 1.34
diff -u -p -u -p -r1.34 Makefile
--- Makefile    19 Jan 2021 06:41:35 -0000      1.34
+++ Makefile    24 Jul 2021 19:08:33 -0000
@@ -3,7 +3,7 @@
 COMMENT =              fast Qt IMAP e-mail client
 
 DISTNAME =             trojita-0.7
-REVISION =             12
+REVISION =             13
 
 SHARED_LIBS =          trojita_plugins 2.0 # 2.0
 
Index: patches/patch-src_Gui_Spinner_h
===================================================================
RCS file: patches/patch-src_Gui_Spinner_h
diff -N patches/patch-src_Gui_Spinner_h
--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ patches/patch-src_Gui_Spinner_h     24 Jul 2021 19:08:33 -0000
@@ -0,0 +1,26 @@
+$OpenBSD$
+
+From e4478df9389894b6498ffe252310cdecd1e58904 Mon Sep 17 00:00:00 2001
+From: Vicente Bergas
+Date: Sat, 3 Feb 2018 19:02:38 +0100
+Subject: [PATCH] Fix signed vs. unsigned math on ARM
+
+On ARM systems, `char` is not signed, but unsigned, and therefore code
+like qMin(-11, ...) doesn't really do a correct thing.
+
+(impacts powerpc as well)
+
+Index: src/Gui/Spinner.h
+--- src/Gui/Spinner.h.orig
++++ src/Gui/Spinner.h
+@@ -82,8 +82,8 @@ private slots:
+     void updateAncestors();
+     void updateGeometry();
+ private:
+-    uchar m_step;
+-    char m_fadeStep;
++    int m_step;
++    int m_fadeStep;
+     int m_timer;
+     QTimer *m_startTimer;
+     QList<QWidget*> m_ancestors;

Reply via email to