Hi, Here is an update for atomicparsley. Upstream moved from bitbucket to github and the project now uses cmake, among many other changes [0].
Port-wise, it's just a minimal port using cmake, i don't have much to say, excepted that i added some fixes for unsigned char archs as reported on macppc (it's upstreamed already). I also shortened the version, that is too lengthy for my taste. It builds and runs fine on macppc and amd64. Comments/feedback are welcome, Charlène. [0] https://github.com/wez/atomicparsley/compare/0.9.6...20210715.151551.e7ad03a Index: Makefile =================================================================== RCS file: /cvs/ports/multimedia/atomicparsley/Makefile,v retrieving revision 1.14 diff -u -p -u -p -r1.14 Makefile --- Makefile 3 Feb 2020 20:40:39 -0000 1.14 +++ Makefile 25 Jul 2021 14:09:53 -0000 @@ -2,33 +2,27 @@ COMMENT= read and set MPEG-4/3GPP metadata tags -V= 0.9.6 -DISTNAME= atomicparsley-$V -REVISION= 4 -DISTFILES= ${DISTNAME}{$V}.tar.bz2 -WRKDIST= ${WRKDIR}/wez-atomicparsley-da2f6e4fc120 +GH_ACCOUNT= wez +GH_PROJECT= atomicparsley +GH_TAGNAME= 20210715.151551.e7ad03a -CATEGORIES= multimedia +DISTNAME= atomicparsley-20210715 -HOMEPAGE= https://bitbucket.org/wez/atomicparsley/ +CATEGORIES= multimedia # GPLv2 "or its successor" PERMIT_PACKAGE= Yes -WANTLIB= c m ${COMPILER_LIBCXX} z +WANTLIB += ${COMPILER_LIBCXX} c m z -COMPILER = base-clang ports-gcc base-gcc +COMPILER = base-clang ports-gcc base-gcc -MASTER_SITES= https://bitbucket.org/wez/atomicparsley/get/ +MODULES = devel/cmake -CONFIGURE_STYLE= autoreconf -CONFIGURE_ENV= ac_cv_func_lroundf=yes \ - OBJCXX="${CXX}" -AUTOCONF_VERSION= 2.69 -AUTOMAKE_VERSION= 1.15 -AUTORECONF= ./autogen.sh +# Don't use git to retrieve the build version +CONFIGURE_ARGS += -DGIT= \ + -DPACKAGE_VERSION="${PKGNAME} (${GH_TAGNAME})" -NO_TEST= Yes -SEPARATE_BUILD= Yes +NO_TEST = Yes .include <bsd.port.mk> Index: distinfo =================================================================== RCS file: /cvs/ports/multimedia/atomicparsley/distinfo,v retrieving revision 1.3 diff -u -p -u -p -r1.3 distinfo --- distinfo 11 Jun 2016 22:12:13 -0000 1.3 +++ distinfo 25 Jul 2021 14:09:53 -0000 @@ -1,2 +1,2 @@ -SHA256 (atomicparsley-0.9.6.tar.bz2) = 4o1GcovoYhnmzkhpXqY32DHKAXDKa9rJmBCZaoKR7lA= -SIZE (atomicparsley-0.9.6.tar.bz2) = 178956 +SHA256 (atomicparsley-20210715.tar.gz) = VG3LXztiWv9Pa/ItJ6CmNtFYVP1ylAKmkz0x89BBfg0= +SIZE (atomicparsley-20210715.tar.gz) = 230214 Index: patches/patch-src_AtomicParsley_h =================================================================== RCS file: patches/patch-src_AtomicParsley_h diff -N patches/patch-src_AtomicParsley_h --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ patches/patch-src_AtomicParsley_h 25 Jul 2021 14:09:53 -0000 @@ -0,0 +1,17 @@ +$OpenBSD$ + +Fix potential bug on unsigned char archs +See https://github.com/wez/atomicparsley/pull/41 + +Index: src/AtomicParsley.h +--- src/AtomicParsley.h.orig ++++ src/AtomicParsley.h +@@ -258,7 +258,7 @@ AtomicInfo *APar_UserData_atom_Init(const char *userda + + /* ID3v2 (2.4) style metadata, non-external form */ + AtomicInfo *APar_ID32_atom_Init(const char *frameID_str, +- char meta_area, ++ signed char meta_area, + const char *lang_str, + uint16_t id32_lang); + Index: patches/patch-src_CDtoc_cpp =================================================================== RCS file: /cvs/ports/multimedia/atomicparsley/patches/patch-src_CDtoc_cpp,v retrieving revision 1.1 diff -u -p -u -p -r1.1 patch-src_CDtoc_cpp --- patches/patch-src_CDtoc_cpp 11 Jun 2016 22:11:53 -0000 1.1 +++ patches/patch-src_CDtoc_cpp 25 Jul 2021 14:09:53 -0000 @@ -1,12 +1,13 @@ $OpenBSD: patch-src_CDtoc_cpp,v 1.1 2016/06/11 22:11:53 sthen Exp $ ---- src/CDtoc.cpp.orig Sat Jun 11 23:06:27 2016 -+++ src/CDtoc.cpp Sat Jun 11 23:06:38 2016 -@@ -71,7 +71,7 @@ CD_TOC_* cdTOC = NULL; - uint8_t LEADOUT_TRACK_NUMBER = MACOSX_LEADOUT_TRACK; - #elif defined (HAVE_LINUX_CDROM_H) - uint8_t LEADOUT_TRACK_NUMBER = CDROM_LEADOUT; --#elif defined (_WIN32) +Index: src/CDtoc.cpp +--- src/CDtoc.cpp.orig ++++ src/CDtoc.cpp +@@ -73,7 +73,7 @@ CD_TOC_ *cdTOC = NULL; + uint8_t LEADOUT_TRACK_NUMBER = MACOSX_LEADOUT_TRACK; + #elif defined(__linux__) + uint8_t LEADOUT_TRACK_NUMBER = CDROM_LEADOUT; +-#elif defined(_WIN32) +#else - uint8_t LEADOUT_TRACK_NUMBER = 0xAA; //NOTE: for WinXP IOCTL_CDROM_READ_TOC_EX code, its 0xA2 + uint8_t LEADOUT_TRACK_NUMBER = + 0xAA; // NOTE: for WinXP IOCTL_CDROM_READ_TOC_EX code, its 0xA2 #endif - Index: patches/patch-src_parsley_cpp =================================================================== RCS file: patches/patch-src_parsley_cpp diff -N patches/patch-src_parsley_cpp --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ patches/patch-src_parsley_cpp 25 Jul 2021 14:09:53 -0000 @@ -0,0 +1,17 @@ +$OpenBSD$ + +Fix potential bug on unsigned char archs +See https://github.com/wez/atomicparsley/pull/41 + +Index: src/parsley.cpp +--- src/parsley.cpp.orig ++++ src/parsley.cpp +@@ -3561,7 +3561,7 @@ AtomicInfo *APar_reverseDNS_atom_Init(const char *rDNS + } + + AtomicInfo *APar_ID32_atom_Init(const char *frameID_str, +- char meta_area, ++ signed char meta_area, + const char *lang_str, + uint16_t id32_lang) { + uint8_t total_tracks = 0;
