On Sat Jul 10, 2021 at 12:28:00PM +0200, Stefan Hagen wrote: > Sebastien Marie wrote: > > On Sat, Jul 10, 2021 at 08:57:45AM +0200, Landry Breuil wrote: > >> here's a quick port for https://github.com/dandavison/delta, a fancy > >> diff viewer that integrates well with git. > >> > >> feedback welcome. > > > > from Makefile: > >> MAKE_ENV += LIBGIT2_SYS_USE_PKG_CONFIG=1 > > > > You shouldn't have to define it: devel/cargo module should pass it to > > the build. If it isn't the case, it is a bug in devel/cargo. > > It does. After I removed this line, it still shows up: > > make show=MODCARGO_ENV > LIBGIT2_SYS_USE_PKG_CONFIG=1 LIBZ_SYS_STATIC=0 RUSTONIG_SYSTEM_LIBONIG=1 > PKG_CONFIG_ALL_DYNAMIC=1 CARGO_HOME=/usr/ports/pobj/delta-0.8.2/cargo-home > CARGO_BUILD_JOBS=1 > CARGO_TARGET_DIR=/usr/ports/pobj/delta-0.8.2/build-amd64/target > RUSTC=/usr/local/bin/rustc RUSTDOC=/usr/local/bin/rustdoc RUSTFLAGS="" > > > Else the port seems fine (but I don't test it). > > Attached is the same port with the following changes: > - removed MAKE_ENV > - added HOMEPAGE
With tabs between "=" and the URL. OK rsadowski > - reordered according to the Makefile template > > Nice diff viewer. Works fine on amd64. > > Best Regards, > Stefan
