On Tue, Jul 27, 2021 at 01:24:01PM +0200, Jeremie Courreges-Anglas wrote:
> On Tue, Jul 27 2021, Kevin Lo <[email protected]> wrote:
> > On Mon, Jul 26, 2021 at 04:36:52PM +0000, openbsd wrote:
> >> 
> >> Hi,
> >> 
> >> This is a minor version bump for fcitx-anthy includes small bug 
> >> fixes/cleanups and translation updates.
> >> 
> >> Tested on amd64 with fcitx-4.2.9.8p1, no problem found.
> >
> > Committed, thanks.
> 
> Note that this adds
> 
>   @tag gtk-update-icon-cache %D/share/icons/hicolor
> 
> without adding an RDEP on x11/gtk+3,-guic.  portcheck(1) even warns
> about this:
> 
>   russell /usr/ports/inputmethods/fcitx-anthy$ portcheck
>   missing RDEP on x11/gtk+3,-guic
> 
> This is not strictly needed since inputmethods/fcitx,-main already
> depends on x11/gtk+3,-guic.  But in theory this could change later.
> I think it's good practice to match "@tag gtk-update-icon-cache" with
> the appropriate RDEP.

Agreed.

> ok?

ok aja


> 
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/inputmethods/fcitx-anthy/Makefile,v
> retrieving revision 1.5
> diff -u -p -r1.5 Makefile
> --- Makefile  27 Jul 2021 01:37:00 -0000      1.5
> +++ Makefile  27 Jul 2021 11:23:10 -0000
> @@ -5,6 +5,7 @@ COMMENT =     anthy wrapper for fcitx
>  GH_ACCOUNT = fcitx
>  GH_PROJECT = fcitx-anthy
>  GH_TAGNAME = 0.2.4
> +REVISION =   0
>  
>  CATEGORIES = inputmethods japanese
>  
> @@ -23,7 +24,8 @@ MODULES =   devel/cmake
>  
>  BUILD_DEPENDS =      devel/gettext,-tools \
>               inputmethods/fcitx,-main
> -RUN_DEPENDS =        inputmethods/fcitx,-main
> +RUN_DEPENDS =        inputmethods/fcitx,-main \
> +             x11/gtk+3,-guic
>  LIB_DEPENDS =        inputmethods/anthy
>  
>  NO_TEST =    Yes
> 
> 
> -- 
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE
> 

-- 
Antoine

Reply via email to