On Sat, Aug 14, 2021 at 06:27:05PM +0200, Stefan Hagen wrote:
> Anindya Mukherjee wrote:
> > Ping
> > 
> > On Tue, Feb 02, 2021 at 11:50:40AM +0000, Stuart Henderson wrote:
> > > start COMMENT with lower-case please (unless it's a proper noun,
> > > but that doesn't apply here).
> > > 
> > > we are a bit busy fixing hundreds of ports for a forthcoming
> > > clang update at the moment so it may take a while to get to it :)
> 
> I reviewed this port. It works fine and it is a useful tool.
> 
> Remarks:
> - NO_TEST=Yes should be set when there are no regression tests
> - pkg/DESCR mentions README.aeidon.md, which is nowhere to be found
> 
> You can either install the file (to share/doc/), or link to the API
> docs directly: https://otsaloma.io/gaupol/doc/api/aeidon.html
> 
> But actually, I think we can omit the paragraph about aeidon. If we want
> it to be used by other software, we should package it independently from
> the GTK UI. Right now, it's only used by gaupol and so I would not give
> it special treatment.
> 
> Portcheck, make lib-depends-check are fine. 
> 
> Thanks for the work!
> 
> Stefan

Hi Stefan,

Thanks a lot for reviewing the port. I have updated it following your
suggestions above. Please have a look.

Regards,
Anindya

Attachment: gaupol.tar.gz
Description: application/tar-gz

Reply via email to